dev@glassfish.java.net

Re: glassfish-corba-omgapi exports javax package

From: Marina Vatkina <Marina.Vatkina_at_Sun.COM>
Date: Tue, 14 Apr 2009 10:31:31 -0700

Marina Vatkina wrote:
> Ken Cavanaugh wrote:
>
>> Sahoo wrote:
>>
>>> Ken Cavanaugh wrote:
>>>
>>>> Sahoo wrote:
>>>>
>>>>> Ken,
>>>>>
>>>>> It exports javax.activation and javax.transaction packages. In
>>>>> fact, it has a partial list of those classes.
>>>>>
>>>> There are several CORBA system exceptions defined in these two
>>>> packages, which were added in
>>>> JDK 5. Is there a split package problem here?
>>>
>>>
>>> yes.
>>>
>>>> What action would you like to take about this?
>>>
>>>
>>> Pl. remove them from those packages and add appropriate
>>> Import-Package statements.
>>>
>> These classes are in the JDK, so I think I just need to remove the
>> packages.
>>
>> Marina, was there a need to include the javax.activity and
>> javax.transaction packages
>> in glassfish-corba-omgapi for JTS?
>
>
> Ken, Sahoo,
>
> This was a part of
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=5370 and this is
> how you Ken explained it last time:
>
> >> I need to change the glassfish-corba-omgapi
> >> bundle. It currently includes everything in:
> >>
> >> javax.activity
> >> javax.transaction
> >> org.omg.PortableServer.POAPackage (actually the bundle include
> org.omg.PortableServer.*)
> >>
> >> The problem we have is that org.omg.CORBA.TSIdentification is needed
> >> in GlassFish, but is not present in the JDK. However, everything else
> >> in org.omg.CORBA is already in the JDK, and we cannot split packages.
> >
> >
>
> There was also an idea to put glassfish-corba-omgapi into
> glassfish/lib/endorsed but it didn't work for me when I tried.

And 2 more email from Ken:

#1.
>> Why does orb bundle have javax.transaction classes? It should just
>> import them rather than having a private copy.
> Not that easy: I use the same ORB code for the JDK and for GF (and I
> will go to extreme lengths to preserve this).
> There is no place to import the classes from in the JDK.

#2.
> Actually, what I should probably do is just remove the javax.transaction classes from omgapi, and
> let felix find them in javaee or javax.transaction or whatever bundle contains them. I can still build
> the ORB with my own version of these classes (which basically never change anyway), and then
> just add an extra dependency in the pom once I get that built.

You were going on vacation at that time :).

Regards,
-marina

>
> regards,
> -marina
>
>>
>> Thanks,
>>
>> Ken.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>