I don't see any issues with your changes.
Thanks,
Jane
Tim Quinn wrote:
> Two changes:
>
> 1. appclient/client/acc/pom.xml: change dependency on an ORB module
> from default to runtime-only
>
> Index: pom.xml
> ===================================================================
> --- pom.xml (revision 25999)
> +++ pom.xml (working copy)
> @@ -313,6 +313,7 @@
> </dependency>
>
> <dependency>
> + <scope>runtime</scope>
> <groupId>org.glassfish.orb</groupId>
> <artifactId>orb-iiop</artifactId>
> <version>${project.version}</version>
>
>
> 2. appclient/client/acc-standalone/pom.xml: change class-path setting
> (still hardcoded until I can get the plug-in to generate the
> version-less JAR names)
>
> The full diff is below, but note that the change is the addition of
> ./webservices-api-osgi.jar to the Class-Path setting. It's not that
> the ACC module depends directly on this but that the transitive
> dependencies have changed.
>
> Thanks.
>
> - Tim
>
> Index: pom.xml
> ===================================================================
> --- pom.xml (revision 25999)
> +++ pom.xml (working copy)
> @@ -211,7 +211,7 @@
> -->
>
> <PreMain-Class>org.glassfish.appclient.client.acc.agent.AppClientContainerAgent</PreMain-Class>
>
>
> - <Class-Path>./glassfish-corba-asm.jar
> ./glassfish-corba-codegen.jar ./glassfish-corba-dynamicany.jar
> ./glassfish-corba-naming.jar ./glassfish-corba-newtimer.jar
> ./glassfish-corba-omgapi.jar ./glassfish-corba-orb.jar
> ./glassfish-corba-orbgeneric.jar ./auto-depends.jar ./config.jar
> ./hk2.jar ./hk2-core.jar ./tiger-types-osgi.jar ./grizzly-comet.jar
> ./grizzly-framework.jar ./grizzly-http.jar ./grizzly-portunif.jar
> ./grizzly-rcm.jar ./grizzly-utils.jar ./pkg-client.jar ./jaxb-osgi.jar
> ./webservices-osgi.jar ./el-api.jar ./servlet-api.jar ./jsp-api.jar
> ./junit.jar ./javax.persistence.jar ./javax.annotation.jar
> ./javax.ejb.jar ./javax.enterprise.deploy.jar ./javax.mail.jar
> ./javax.resource.jar ./javax.security.auth.message.jar
> ./javax.security.jacc.jar ./javax.servlet.jar ./javax.servlet.jsp.jar
> ./javax.transaction.jar ./admin-core.jar ./admin-util.jar
> ./cli-framework.jar ./config-api.jar ./monitoring-core.jar
> ./acc-config.jar ./gf-client-module.jar ./amx-api.jar
> ./annotation-framework.jar ./common-util.jar ./container-common.jar
> ./glassfish-api.jar ./glassfish-naming.jar ./internal-api.jar
> ./stats77.jar ./connectors-internal-api.jar ./glassfish.jar
> ./kernel.jar ./deployment-common.jar ./deployment-javaee-core.jar
> ./dol.jar ./dtds.zip ./ejb-container.jar ./ejb-internal-api.jar
> ./apache-commons.jar ./asm-all-repackaged.jar ./ldapbp-repackaged.jar
> ./flashlight-agent.jar ./flashlight-framework.jar ./orb-connector.jar
> ./orb-iiop.jar ./appclient.security.jar ./realms.jar ./security.jar
> ./securitycommon.jar ./websecurity.jar ./webservices.security.jar
> ./transaction-internal-api.jar ./el-impl.jar ./jsp-impl.jar
> ./war-util.jar ./web-cli.jar ./web-core.jar ./web-glue.jar
> ./web-gui-plugin-common.jar ./web-naming.jar
> ./jsr109-impl.jar</Class-Path>
> + <Class-Path>./glassfish-corba-asm.jar
> ./glassfish-corba-codegen.jar ./glassfish-corba-dynamicany.jar
> ./glassfish-corba-naming.jar ./glassfish-corba-newtimer.jar
> ./glassfish-corba-omgapi.jar ./glassfish-corba-orb.jar
> ./glassfish-corba-orbgeneric.jar ./auto-depends.jar ./config.jar
> ./hk2.jar ./hk2-core.jar ./tiger-types-osgi.jar ./grizzly-comet.jar
> ./grizzly-framework.jar ./grizzly-http.jar ./grizzly-portunif.jar
> ./grizzly-rcm.jar ./grizzly-utils.jar ./pkg-client.jar ./jaxb-osgi.jar
> ./webservices-osgi.jar ./el-api.jar ./servlet-api.jar ./jsp-api.jar
> ./webservices-api-osgi.jar ./junit.jar ./javax.persistence.jar
> ./javax.annotation.jar ./javax.ejb.jar ./javax.enterprise.deploy.jar
> ./javax.mail.jar ./javax.resource.jar
> ./javax.security.auth.message.jar ./javax.security.jacc.jar
> ./javax.servlet.jar ./javax.servlet.jsp.jar ./javax.transaction.jar
> ./admin-core.jar ./admin-util.jar ./cli-framework.jar ./config-api.jar
> ./monitoring-core.jar ./acc-config.jar ./gf-client-module.jar
> ./amx-api.jar ./annotation-framework.jar ./common-util.jar
> ./container-common.jar ./glassfish-api.jar ./glassfish-naming.jar
> ./internal-api.jar ./stats77.jar ./connectors-internal-api.jar
> ./glassfish.jar ./kernel.jar ./deployment-common.jar
> ./deployment-javaee-core.jar ./dol.jar ./dtds.zip ./ejb-container.jar
> ./ejb-internal-api.jar ./apache-commons.jar ./asm-all-repackaged.jar
> ./ldapbp-repackaged.jar ./flashlight-agent.jar
> ./flashlight-framework.jar ./orb-connector.jar ./orb-iiop.jar
> ./appclient.security.jar ./realms.jar ./security.jar
> ./securitycommon.jar ./websecurity.jar ./webservices.security.jar
> ./transaction-internal-api.jar ./el-impl.jar ./jsp-impl.jar
> ./war-util.jar ./web-cli.jar ./web-core.jar ./web-glue.jar
> ./web-gui-plugin-common.jar ./web-naming.jar
> ./jsr109-impl.jar</Class-Path>
> </manifestEntries>
>
> </archive>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>