dev@glassfish.java.net

Re: moving tests from v2/appserv-test

From: Justin Lee <Justin.Lee_at_Sun.COM>
Date: Wed, 18 Mar 2009 14:55:22 -0400

Since there's some question about the what and where of the tests, we
decided in our meeting today to just wait until there's a more universal
idea about how to handle those tests.

Jerome Dochez wrote:
>
> On Mar 18, 2009, at 8:41 AM, Sahoo wrote:
>
>> I really don't like to check out something that I don't use during my
>> regular build. Putting them in v3/web/tests will force me to check
>> out the tests. I don't think svn has a notion of modules as CVS. So,
>> I suggest you put the web tests under v3/tests/web so that we have an
>> option to create a top level src directory under v3 and move all the
>> sources to v3/src.
> instead of moving existing code, should we move all devtests under a
> directory unrelated to v3 ?
>
> v3 should eventually be renamed src and we could have devtests at the
> same leve.
>
> src (all sources we checkout and build)
> devtests (devtests)
> other (sources we might build separately, like web-beans)
>
> jerome
>
>>
>>
>> Sahoo
>>
>> Justin Lee wrote:
>>> The plan is to put them in v3/web/tests/test for now and as we
>>> migrate to/add more formal testng tests, add them in src/test.
>>>
>>> Seeing no objections then, i'll make this change later today or
>>> early tomorrow morning provided no subsequent objections arise in
>>> the interim. Thanks for your input.
>>>
>>> Sahoo wrote:
>>>> If these tests are run as part of mvn test/install phase, then they
>>>> should be part of src/test, otherwise I prefer not to see them part
>>>> of src tree.
>>>>
>>>> Thanks,
>>>> Sahoo
>>>>
>>>> Justin Lee wrote:
>>>>> The webtier team talked and decided we'd like to move our tests
>>>>> out of the v2 tree into some location in the v3 tree. It's
>>>>> confusing to have our tests so "far" from our code especially
>>>>> given that many would prefer to just check out the v3 tree. We'd
>>>>> originally thought to move our tests from
>>>>> v2/appserv-test/devtests/web to v3/web/tests but thought we'd get
>>>>> some guidance first. We noticed that in v3/tests tree there are
>>>>> not only the quicklook tests but a tree with amx tests as well.
>>>>> So there's at least *some* precedence for putting tests there.
>>>>> Our question, then, is: which is the preferred approach?
>>>>>
>>>>> The "Maven Way(tm)" is to have the tests in src/test in the module
>>>>> to which they apply and this was our original intent. But if
>>>>> there's a general trend/preference to put v3 tests under v3/tests
>>>>> then that's something we'd want to adhere to. Is there an
>>>>> official recommendation for this kind of thing? Is there already
>>>>> work being done along these lines that we should just wait for?
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>