On Mon, 2009-01-05 at 16:31, Dies Koper wrote:
> Last month Ken (kcavanaugh) mentioned that the CORBA source has been
> moved to Kenai project and all the details were on
> http://glassfish-corba.dev.java.net.
>
> I'm looking for details on how to submit patches to this project.
>
> The guidelines and conventions page (below) says to use cvs.
> https://glassfish.dev.java.net/public/GuidelinesandConventions.html
Note that this is for glassfish, not glassfish-corba. We'll need to
work out how to do this for GlassFish CORBA.
>
> I don't need to use some Mercurial way to prepare a patch file?
It's pretty easy to handle diffs in mercurial, but I'll need to put
together the details.
>
> I'd like to prepare a patch for issue 6776. Could someone in the CORBA
> team take a look at this issue first and tell me what you think? Would
> you be interested in a patch?
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=6776
>
Yes, I'm interested in a patch. Send me the details and I'll evaluate
the change.
We need to be very careful with the Threadpool code. It's been
problematic in many cases,
and I have some memory leak fixes coming into the released code from a
JDK bug.
I assume that you are mostly interested in the GFv2 code? The GFv3 ORB
has quite a number
of changes, and will need a separate patch. However, a GFv2 patch could
probably be
directly applied to the GFv2 master repository.
I think you'll also need to fill out the Sun contributor agreement, if
you have not already
done so.
By the way, this is the first outside patch for CORBA in GlassFish we've
every had, so the procedure
needs some work :-).
Thanks,
Ken.