Sahoo wrote:
> Yes, the build does report a WARNING for unused export statements.
> Check your build log.
Ah, yes, now that I look for it buried in the middle of my build log:
[WARNING] Warning in manifest for
org.glassfish.deployment:deployment-admin:hk2-jar:10.0-SNAPSHOT :
Superfluous export-package instructions: [com.sun.enterprise.v3.deployment]
It does rather get lost amid the many warnings like this
[WARNING] Removing: jar from forked lifecycle, to prevent recursive
invocation.
that I assume are not something the engineer needs to do something
about, whereas the 28 (27 now that I fixed the one) "Superfluous
export-package" warnings are something people should be cleaning up, I
guess.
It would be better if the final message said "BUILD COMPLETE WITH
WARNING" instead of "BUILD SUCCESSFUL" and if the reactor summary of all
the modules showed "warning" instead of "success" for modules that built
with warnings. Someone might reasonably point out that most if not all
of the modules would then have "warning" as their build status, to which
I'd say that if the warnings are not something that need to be taken
care of they should not be logged as warnings.
- Tim
>
> Thanks,
> Sahoo
>
> Tim Quinn wrote:
>> Problem solved.
>>
>> I had not changed the osgi.bundle file in the module where I renamed
>> the classes. So the newly-renamed classes were never visible outside
>> the module.
>>
>> I think it would be good if the build would warn (or fail?) if the
>> osgi.bundle file specifies exports that match no classes in the module.
>>
>> I am also not sure why my local build worked fine. A puzzle for
>> another day...
>>
>> - Tim
>>
>> Tim Quinn wrote:
>>> I checked in some "simple" file renaming changes and now the server
>>> won't restart on Hudson for the QL jobs. I downloaded the web.xml
>>> used by the devbuild QL tests and it does not start for me locally
>>> either.
>>>
>>> I am investigating but would welcome any advice on finding the problem.
>>> The server reports the errors below but there is not enough to
>>> reveal the underlying cause. The class it says it cannot find
>>> refers to another class in the autodeployer that in turn refers to a
>>> service "deploy.command" that is provided by one of the renamed
>>> classes. So I suspect that may be related to the problem but my
>>> search of the code base well before my check-in revealed no other
>>> references to the package I renamed.
>>> - Tim
>>>
>>> [#|2008-09-01T14:16:56.909-0700|INFO||org.jvnet.hk2.osgiadapter|_ThreadID=12;_ThreadName=Thread-3;org.glassfish.deployment.deployment-autodeploy
>>> [42];|Started bundle org.glassfish.deployment.deployment-autodeploy
>>> [42]|#]
>>>
>>> [#|2008-09-01T14:16:56.910-0700|SEVERE||org.jvnet.hk2.osgiadapter|_ThreadID=12;_ThreadName=Thread-3;|Exception
>>> in module org.glassfish.deployment.deployment-autodeploy [42] :
>>> java.lang.ClassNotFoundException:
>>> org.glassfish.deployment.autodeploy.AutoDeployService|#]
>>>
>>> [#|2008-09-01T14:16:56.910-0700|SEVERE||null|_ThreadID=12;_ThreadName=Thread-3;|Exception
>>> in thread "GlassFish Kernel Main Thread" |#]
>>>
>>> [#|2008-09-01T14:16:56.982-0700|SEVERE||null|_ThreadID=12;_ThreadName=Thread-3;|org.jvnet.hk2.component.ComponentException:
>>> Failed to load org.glassfish.deployment.autodeploy.AutoDeployService
>>> from org.jvnet.hk2.osgiadapter.OSGiModuleImpl$1$1_at_8b058b|#]
>>>
>>> [#|2008-09-01T14:16:56.983-0700|SEVERE||null|_ThreadID=12;_ThreadName=Thread-3;|
>>> at
>>> com.sun.hk2.component.LazyInhabitant.fetch(LazyInhabitant.java:94)|#]
>>>
>>> [#|2008-09-01T14:16:56.983-0700|SEVERE||null|_ThreadID=12;_ThreadName=Thread-3;|
>>> at com.sun.hk2.component.LazyInhabitant.type(LazyInhabitant.java:78)|#]
>>>
>>> [#|2008-09-01T14:16:56.983-0700|SEVERE||null|_ThreadID=12;_ThreadName=Thread-3;|
>>> at
>>> com.sun.enterprise.v3.server.AppServerStartup.run(AppServerStartup.java:163)|#]
>>>
>>>
>>> [#|2008-09-01T14:16:56.983-0700|SEVERE||null|_ThreadID=12;_ThreadName=Thread-3;|
>>> at
>>> com.sun.enterprise.v3.server.AppServerStartup$1.run(AppServerStartup.java:103)|#]
>>>
>>>
>>> [#|2008-09-01T14:16:56.983-0700|SEVERE||null|_ThreadID=12;_ThreadName=Thread-3;|Caused
>>> by: java.lang.ClassNotFoundException:
>>> org.glassfish.deployment.autodeploy.AutoDeployService|#]
>>>
>>> [#|2008-09-01T14:16:56.984-0700|SEVERE||null|_ThreadID=12;_ThreadName=Thread-3;|
>>> at
>>> org.jvnet.hk2.osgiadapter.OSGiModuleImpl$1$1.loadClass(OSGiModuleImpl.java:266)|#]
>>>
>>>
>>> [#|2008-09-01T14:16:56.984-0700|SEVERE||null|_ThreadID=12;_ThreadName=Thread-3;|
>>> at
>>> com.sun.hk2.component.LazyInhabitant.fetch(LazyInhabitant.java:91)|#]
>>>
>>> [#|2008-09-01T14:16:56.984-0700|SEVERE||null|_ThreadID=12;_ThreadName=Thread-3;|
>>> ... 3 more|#]
>>>
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>