Amy Roh wrote:
> Jerome Dochez wrote:
>>
>> On Sep 10, 2008, at 12:50 PM, Amy Roh wrote:
>>
>>> Kedar Mhaswade wrote:
>>>>
>>>>> The patch will regress because dynamic reconfig was written based
>>>>> on http-service CHANGE events for handling http-service
>>>>> properties\attributes changes rather than registering a
>>>>> ConfigListener for each
>>>>> com.sun.enterprise.config.serverbeans.Property itself. This is
>>>>> why Jerome added parent notification. Again, we could fine-tune
>>>>> each Property notification to get handled separately and that'll
>>>>> take some time.
>>>>>
>>>> Does this mean that you do in fact rely on http-service CHANGE to be
>>>> delivered upon creation/deletion of a property or any other child?
>>>> This contradicts with what Jan said earlier -- CHANGE event on
>>>> http-service
>>>> should not have been delivered on creation of an http-listener.
>>>
>>> I agree with Jan that CHANGE event on http-service delivered on
>>> creation of an http-listener is unnecessary. CHANGE event on
>>> http-service should be delivered when, in fact, http-service
>>> property/attribute has been changed. Property dynamic reconfig rely
>>> on parent's CHANGE notification.
>>>
>>>> So, for Prelude, how should 6001 be fixed? (Note -- I want to minimize
>>>> the changes and I agree that this has been confusing for a long time).
>>>
>>> As Jan suggested earlier, if we could somehow limit/avoid CHANGE
>>> event on http-service when http-listener is created, we can avoid
>>> restarting all http-listeners. Within ConfigListener
>>> implementation, AFAIK, cannot tell whether CHANGE event on
>>> http-service is from http-listener creation or Property change on
>>> http-service.
>> have you tried what I suggested yesterday ? what is the CHANGE
>> event.getSource() object, is it http-service or is the new created
>> http-listener ?
>
> As stated in the bug report 6001, during create-http-listener and
> delete-http-listener, events are -
>
> ADD com.sun.enterprise.config.serverbeans.HttpListener
>
> CHANGE com.sun.enterprise.config.serverbeans.HttpService
>
> REMOVE com.sun.enterprise.config.serverbeans.HttpListener
>
> Amy
>
sorry I missed that...
so you can know which type of change you are getting.
for instance if you add a http-listener to the http-service, the change
event should have the following characteristics :
event.getSource() Http-Service instace
event.getOldValue null
event.getNewValue http-listener
for property :
event.getSource() Property instance
event.getOldValue foo
event.getNewValue bar
would that be enough ?
>>
>> thanks, jerome
>>
>>>
>>>
>>> Amy
>>>>
>>>> Thanks,
>>>> Kedar
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>