I am confused.
Why would dynamically added/deleted virtual-server, http-listener, property be
handled as a CHANGE event on http-service? It should be handled as explicit
ADD/DELETE on http-service, isn't it? Any change to virtual-server/property etc.
in turn should be delivered as CHANGE to *that element* rather than http-service
which is a parent element.
Like I said, the CHANGE event on http-service should really be sent from
the config only if http-service element was CHANGED (without any addition
or deletion of a child element). This leaves only element's CDATA or attributes.
There isn't any of this for http-service, so I thought the work-around should
work for every case.
My expectation (based on the limited understanding of dynamic reconfig
framework) is that Jan's patch should have not regressed anything. Is
that not true?
-Kedar
Amy Roh wrote:
> Jan Luehe wrote:
>> Kedar,
>>
>> On 09/ 9/08 04:57 PM, Kedar Mhaswade wrote:
>>
>>>
>>>
>>> Jan,
>>>
>>> A quick check on http-service reveals that there are no attributes on
>>> it. So, till Jerome/I get time to investigate this, can you just ignore
>>> the CHANGE event on element http-service to resolve this immediate
>>> problem?
>>
>>
>> Yes, the attached diffs make QL pass for me consistently.
>>
>> I'd like for Amy to have the last word on this, though, to see if any
>> of our unit
>> tests might fail with this temporary workaround in place.
>
> Many unit tests will fail with the patch below since it is ignoring any
> change to HttpService (all http-service properties, dynamically added
> virtual-server, and http-listener, etc.) We could try to fine-tune each
> Property notification to get handled separately, however, dynamically
> added virtual-server and http-listener all currently depend on
> http-service change event.
>
> Amy
>
>>
>> Thanks,
>>
>> Jan
>>
>>
>> ------------------------------------------------------------------------
>>
>> Index:
>> web/web-glue/src/main/java/com/sun/enterprise/web/reconfig/HttpServiceConfigListener.java
>>
>> ===================================================================
>> ---
>> web/web-glue/src/main/java/com/sun/enterprise/web/reconfig/HttpServiceConfigListener.java
>> (revision 22504)
>> +++
>> web/web-glue/src/main/java/com/sun/enterprise/web/reconfig/HttpServiceConfigListener.java
>> (working copy)
>> @@ -165,6 +165,9 @@
>> container.configureHttpProtocol(httpService);
>> } else if (t instanceof HttpFileCache) {
>> container.configureFileCache(httpService);
>> + } else if (t instanceof HttpService) {
>> + // Workaround for Issue 6001
>> + return null;
>> }
>> container.updateHttpService(httpService);
>> } catch (LifecycleException le) {
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>