Kedar Mhaswade wrote:
> All I am saying is you should consult the original author if you
> are making changes to someone else's code. This issue is being
> investigated actively (as you probably know) and I expected
> at least a heads-up that said what you were going to do.
Sorry, my mistake. I thought Ming is the author and owns the QuickLook
test as he tests the changes in my office with my machine and told me to
check that in for him.
Anissa.
> Thanks.
>
> Anissa Lam wrote:
>> Hi Kedar,
>>
>> I did that upon the request of the QE team as a temporary
>> workaround, so that other developer can at least run the quicklook
>> test and commit according to the 'checkin rule'. Please talk with
>> Sherry and Ming if you think this is not appropriate and prefer to
>> revert the changes while they are looking for a permanent solution.
>>
>> thanks
>> Anissa.
>>
>> Kedar Mhaswade wrote:
>>> PLEASE, don't do such workarounds, because it masks problems
>>> elsewhere and more importantly, please consult the author of
>>> this code first.
>>>
>>>
>>>
>>>
>>> anilam_at_dev.java.net wrote:
>>>> Author: anilam
>>>> Date: 2008-09-10 00:12:09+0000
>>>> New Revision: 22513
>>>>
>>>> Modified:
>>>> trunk/v3/tests/quicklook/testng.xml
>>>>
>>>> Log:
>>>> This is a workaround for issue# 6001. By moving the "asadmin_test"
>>>> to the end of the suites so that it is run after all other tests is
>>>> run, we no longer see the ConnectException.
>>>> Tested on Anissa's dual core Mac.
>>>>
>>>>
>>>>
>>>> Modified: trunk/v3/tests/quicklook/testng.xml
>>>> Url:
>>>> https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/tests/quicklook/testng.xml?view=diff&rev=22513&p1=trunk/v3/tests/quicklook/testng.xml&p2=trunk/v3/tests/quicklook/testng.xml&r1=22512&r2=22513
>>>>
>>>> ==============================================================================
>>>>
>>>> --- trunk/v3/tests/quicklook/testng.xml (original)
>>>> +++ trunk/v3/tests/quicklook/testng.xml 2008-09-10 00:12:09+0000
>>>> @@ -41,13 +41,6 @@
>>>> <parameter name="admin.password" value=""/>
>>>> <parameter name="admin.console.url"
>>>> value="http://localhost:4848/"/>
>>>> <parameter name="resources.xml.relative.path"
>>>> value="admin/resources/resources.xml"/>
>>>> - <test name="asadmin_tests">
>>>> - <classes>
>>>> - <class name="test.admin.JvmOptionTests"/>
>>>> - <class name="test.admin.JdbcConnectionPoolTests"/>
>>>> - <class name="test.admin.WebtierTests"/>
>>>> - </classes>
>>>> - </test>
>>>> <!--
>>>> <test name="adminconsole_tests">
>>>> <classes>
>>>> @@ -110,5 +103,12 @@
>>>> <class name="ejb30.session.hello.test.TestClient" />
>>>> </classes>
>>>> </test>--> + <test name="asadmin_tests">
>>>> + <classes>
>>>> + <class name="test.admin.JvmOptionTests"/>
>>>> + <class name="test.admin.JdbcConnectionPoolTests"/>
>>>> + <class name="test.admin.WebtierTests"/>
>>>> + </classes>
>>>> + </test>
>>>> </suite>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: commits-unsubscribe_at_glassfish-svn.dev.java.net
>>>> For additional commands, e-mail:
>>>> commits-help_at_glassfish-svn.dev.java.net
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>