Jerome Dochez wrote:
> this is incorrect.
Regressing on existing tp2 functionality is unacceptable.
> kernel must not depend on realms which depends on DOL which depends on
> many things including the Java EE Apis.
> 1. the classes you just checked in already existed in the realm module
> where they got moved some time back.
That move regressed tp2 functionality because all the 7 missing (moved)
commands are no longer available (refer to issue 5112).
QA has been blocked on missing commands. I wonder how this slipped
during verification testing after the classes were moved.
With ref to issue 5112, I had written to you for details on why the
commands corresponding to these classes were left out in trunk. I
received no replies.
I did not find them in the dir they were checked in, and the
functionality was broken; I concluded classes were perhaps left out
inadvertently during tp2 branch to trunk syncing. (see my comments in 5112).
> 2. never modify the import list of kernel and nucleus related modules
> without talking to myself or sahoo first.
Likewise, appreciate if we are made aware of modifications such as
moving of the classes in admin. No one in admin team seems to be aware
of this move.
> Please revert this change and fix anything that needs to be fixed in
> the Realm module directly.
I can revert my change but then moved classes need to work from their
new location. QA will be stuck otherwise. Let me know.
thanks,
Nandini
> thanks, jerome
>
> On Jun 25, 2008, at 6:22 PM, ne110415_at_dev.java.net wrote:
>
>> Author: ne110415
>> Date: 2008-06-26 01:22:06+0000
>> New Revision: 21133
>>
>> Modified:
>> trunk/v3/core/kernel/pom.xml
>>
>> Log:
>> Missing commands from TP2. Issue 5112 gets addressed.
>>
>> Modified: trunk/v3/core/kernel/pom.xml
>> Url:
>> https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/core/kernel/pom.xml?view=diff&rev=21133&p1=trunk/v3/core/kernel/pom.xml&p2=trunk/v3/core/kernel/pom.xml&r1=21132&r2=21133
>>
>> ==============================================================================
>>
>> --- trunk/v3/core/kernel/pom.xml (original)
>> +++ trunk/v3/core/kernel/pom.xml 2008-06-26 01:22:06+0000
>> @@ -102,6 +102,11 @@
>> <version>${hk2.version}</version>
>> </dependency>
>> <dependency>
>> + <groupId>org.glassfish.security</groupId>
>> + <artifactId>realms</artifactId>
>> + <version>${project.version}</version>
>> + </dependency>
>> + <dependency>
>> <groupId>org.glassfish.external</groupId>
>> <artifactId>grizzly-module</artifactId>
>> <version>${grizzly.version}</version>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commits-unsubscribe_at_glassfish-svn.dev.java.net
>> For additional commands, e-mail: commits-help_at_glassfish-svn.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>