fyi, build is broken, Kedar is working on it.
Begin forwarded message:
> From: Kedar Mhaswade <Kedar.Mhaswade_at_Sun.COM>
> Date: March 14, 2008 10:40:40 AM PDT
> To: Dinesh Patil <Dinesh.Patil_at_Sun.COM>
> Cc: Jerome Dochez <Jerome.Dochez_at_Sun.COM>, Abhijit Kumar <Abhijit.Kumar_at_Sun.COM
> >, Kohsuke Kawaguchi <Kohsuke.Kawaguchi_at_Sun.COM>
> Subject: Re: svn commit: r18837 - trunk/v3/admin/config-api/src:
> main/java/com/sun/enterprise/config/serverbeans test/java/com/sun/
> enterprise/configapi/tests/dv...
>
> Dinesh,
>
> I've made a commit.
> Please see if it improves the situation. Sorry for the trouble.
>
> BTW, can you tell me why gf:run does not work (my other e-mail)?
> I was not able to start the server and make sure if my changes
> were right, last night.
>
> Regards,
> Kedar
>
> Dinesh Patil wrote:
>> Looks like after this checkin QL is failing. pls take a look at
>> server.log that's printed at the end of QL run in same console log.
>> Last QL passed is @11pm yesterday: http://kohsuke.sfbay/hudson/view/GFv3/job/v3-quicklook/2496/
>> [#|2008-03-14T09:43:54.664-0700|SEVERE|GlassFish10.0|
>> javax.enterprise.system.container.web|
>> _ThreadID=12;_ThreadName=Thread-4;|WEB0348: Illegal access log
>> pattern [null], is not a valid nickname and does not contain any % |
>> #]
>> [#|2008-03-14T09:43:54.666-0700|SEVERE|GlassFish10.0|
>> javax.enterprise.system.tools.deployment|
>> _ThreadID=12;_ThreadName=Thread-4;|Cannot start container from
>> module Module:
>> org
>> .glassfish
>> .web:webtier::ModuleClassLoader(name=org.glassfish.web:webtier,
>> parent=,URls[]=file:/files/hudson/workspace/v3-quicklook/glassfish/
>> modules/./web/webtier-10.0-SNAPSHOT.jar,file:/files/hudson/
>> workspace/v3-quicklook/glassfish/modules/web/jasper-
>> jsr199-9.1.jar,),init=true,URls[]=file:/files/hudson/workspace/v3-
>> quicklook/glassfish/modules/./web/webtier-10.0-SNAPSHOT.jar,file:/
>> files/hudson/workspace/v3-quicklook/glassfish/modules/web/jasper-
>> jsr199-9.1.jar,) java.lang.NullPointerException
>> at com.sun.enterprise.web.accesslog.DefaultAccessLogFormatterImpl.parsePattern
>> (DefaultAccessLogFormatterImpl.java:271) at com.sun.enterprise.web.accesslog.DefaultAccessLogFormatterImpl
>> .<init>(DefaultAccessLogFormatterImpl.java:143) at
>> com
>> .sun
>> .enterprise.web.PEAccessLogValve.setPattern(PEAccessLogValve.java:
>> 428) at com.sun.enterprise.web.PEAccessLogValve.updateAccessLogAttributes
>> (PEAccessLogValve.java:853) at com.sun.enterprise.web.PEAccessLogValve.configure
>> (PEAccessLogValve.java:727) at com.sun.enterprise.web.WebContainer.createVirtualServer
>> (WebContainer.java:1068) at com.sun.enterprise.web.WebContainer.postConstruct
>> (WebContainer.java:422)
>> at
>> com.sun.hk2.component.AbstractWombImpl.inject(AbstractWombImpl.java:
>> 114)
>> at
>> com
>> .sun.hk2.component.ConstructorWomb.initialize(ConstructorWomb.java:
>> 50)
>> at
>> com.sun.hk2.component.AbstractWombImpl.get(AbstractWombImpl.java:39)
>> at
>> com
>> .sun.hk2.component.SingletonInhabitant.get(SingletonInhabitant.java:
>> 22)
>> at com.sun.hk2.component.LazyInhabitant.get(LazyInhabitant.java:
>> 71)
>> at
>> com
>> .sun
>> .hk2
>> .component.AbstractInhabitantImpl.get(AbstractInhabitantImpl.java:
>> 24) at
>> com
>> .sun
>> .enterprise.v3.data.ContainerInfo.getContainer(ContainerInfo.java:
>> 76) at
>> com
>> .sun
>> .enterprise
>> .v3
>> .server
>> .ApplicationLifecycle.startContainers(ApplicationLifecycle.java:
>> 677) at
>> com
>> .sun
>> .enterprise
>> .v3
>> .server
>> .ApplicationLifecycle.setupContainerInfos(ApplicationLifecycle.java:
>> 398) at
>> com
>> .sun
>> .enterprise
>> .v3.server.ApplicationLifecycle.deploy(ApplicationLifecycle.java:
>> 260) at
>> com
>> .sun
>> .enterprise.v3.deployment.DeployCommand.execute(DeployCommand.java:
>> 289) at
>> com
>> .sun.enterprise.v3.admin.CommandRunner.doCommand(CommandRunner.java:
>> 181)
>> at
>> com
>> .sun.enterprise.v3.admin.CommandRunner.doCommand(CommandRunner.java:
>> 79)
>> at
>> com
>> .sun.enterprise.v3.admin.AdminAdapter.doCommand(AdminAdapter.java:
>> 152)
>> at
>> com.sun.enterprise.v3.admin.AdminAdapter.service(AdminAdapter.java:
>> 109)
>> at
>> com
>> .sun
>> .grizzly
>> .http.DefaultProcessorTask.invokeAdapter(DefaultProcessorTask.java:
>> 605) at
>> com
>> .sun
>> .grizzly
>> .http.DefaultProcessorTask.doProcess(DefaultProcessorTask.java:
>> 536) at
>> com
>> .sun
>> .grizzly
>> .http.DefaultProcessorTask.process(DefaultProcessorTask.java:
>> 785) at
>> com
>> .sun
>> .grizzly
>> .http.DefaultProtocolFilter.execute(DefaultProtocolFilter.java:
>> 130) at
>> com
>> .sun
>> .enterprise
>> .v3
>> .services.impl.HttpProtocolFilter.execute(HttpProtocolFilter.java:
>> 99) at
>> com
>> .sun
>> .enterprise
>> .v3
>> .services
>> .impl
>> .GlassfishProtocolChain
>> .executeProtocolFilter(GlassfishProtocolChain.java:61) at
>> com
>> .sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:
>> 78)
>> at
>> com
>> .sun
>> .grizzly
>> .ProtocolChainContextTask.doCall(ProtocolChainContextTask.java:
>> 54) at
>> com
>> .sun
>> .grizzly.SelectionKeyContextTask.call(SelectionKeyContextTask.java:
>> 57) at
>> com.sun.grizzly.util.WorkerThreadImpl.run(WorkerThreadImpl.java:179)
>> |#]
>> km_at_dev.java.net wrote:
>>> Author: km
>>> Date: 2008-03-14 06:02:57+0000
>>> New Revision: 18837
>>>
>>> Added:
>>> trunk/v3/admin/config-api/src/test/java/com/sun/enterprise/
>>> configapi/tests/dvt/AccessLogAllDefaultsTest.java
>>> trunk/v3/admin/config-api/src/test/resources/
>>> AccessLogAllDefaultsTest.xml
>>> Modified:
>>> trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/
>>> config/serverbeans/AccessLog.java
>>> trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/
>>> config/serverbeans/Action.java
>>> trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/
>>> config/serverbeans/AdminObjectResource.java
>>> trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/
>>> config/serverbeans/AdminService.java
>>> trunk/v3/admin/config-api/src/test/java/com/sun/enterprise/
>>> configapi/tests/dvt/JdbcConnectionPoolDefaultsTest.java
>>>
>>> Log:
>>> More config interfaces have default values now.
>>>
>>>
>>> Modified: trunk/v3/admin/config-api/src/main/java/com/sun/
>>> enterprise/config/serverbeans/AccessLog.java
>>> Url: https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/AccessLog.java?view=diff&rev=18837&p1=trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/AccessLog.java&p2=trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/AccessLog.java&r1=18836&r2=18837
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ====================================================================
>>> --- trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/
>>> config/serverbeans/AccessLog.java (original)
>>> +++ trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/
>>> config/serverbeans/AccessLog.java 2008-03-14 06:02:57+0000
>>> @@ -42,9 +42,7 @@
>>> import org.jvnet.hk2.config.Configured;
>>> import org.jvnet.hk2.config.ConfigBeanProxy;
>>> import org.jvnet.hk2.component.Injectable;
>>> -
>>> import java.beans.PropertyVetoException;
>>> -import java.io.Serializable;
>>> import com.sun.appserv.management.annotation.AMXConfigInfo;
>>> @@ -62,7 +60,7 @@
>>> * @return possible object is
>>> * {_at_link String }
>>> */
>>> - @Attribute
>>> + @Attribute (defaultValue="%client.name% %auth-user-name%
>>> %datetime% %request% %status% %response.length%")
>>> public String getFormat();
>>> /**
>>> @@ -79,7 +77,7 @@
>>> * @return possible object is
>>> * {_at_link String }
>>> */
>>> - @Attribute
>>> + @Attribute (defaultValue="time")
>>> public String getRotationPolicy();
>>> /**
>>> @@ -96,7 +94,7 @@
>>> * @return possible object is
>>> * {_at_link String }
>>> */
>>> - @Attribute
>>> + @Attribute (defaultValue="1440")
>>> public String getRotationIntervalInMinutes();
>>> /**
>>> @@ -113,7 +111,7 @@
>>> * @return possible object is
>>> * {_at_link String }
>>> */
>>> - @Attribute
>>> + @Attribute (defaultValue="yyyyMMdd-HH'h'mm'm'ss's'")
>>> public String getRotationSuffix();
>>> /**
>>> @@ -130,7 +128,7 @@
>>> * @return possible object is
>>> * {_at_link String }
>>> */
>>> - @Attribute
>>> + @Attribute (defaultValue="true")
>>> public String getRotationEnabled();
>>> /**
>>>
>>> Modified: trunk/v3/admin/config-api/src/main/java/com/sun/
>>> enterprise/config/serverbeans/Action.java
>>> Url: https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/Action.java?view=diff&rev=18837&p1=trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/Action.java&p2=trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/Action.java&r1=18836&r2=18837
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ====================================================================
>>> --- trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/
>>> config/serverbeans/Action.java (original)
>>> +++ trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/
>>> config/serverbeans/Action.java 2008-03-14 06:02:57+0000
>>> @@ -44,8 +44,6 @@
>>> import org.jvnet.hk2.component.Injectable;
>>> import java.beans.PropertyVetoException;
>>> -import java.io.Serializable;
>>> -
>>> /**
>>> *
>>>
>>> Modified: trunk/v3/admin/config-api/src/main/java/com/sun/
>>> enterprise/config/serverbeans/AdminObjectResource.java
>>> Url: https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/AdminObjectResource.java?view=diff&rev=18837&p1=trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/AdminObjectResource.java&p2=trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/AdminObjectResource.java&r1=18836&r2=18837
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ====================================================================
>>> --- trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/
>>> config/serverbeans/AdminObjectResource.java (original)
>>> +++ trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/
>>> config/serverbeans/AdminObjectResource.java 2008-03-14
>>> 06:02:57+0000
>>> @@ -45,7 +45,6 @@
>>> import org.jvnet.hk2.component.Injectable;
>>> import java.beans.PropertyVetoException;
>>> -import java.io.Serializable;
>>> import java.util.List;
>>> @@ -118,7 +117,7 @@
>>> * @return possible object is
>>> * {_at_link String }
>>> */
>>> - @Attribute + @Attribute (defaultValue="user")
>>> public String getObjectType();
>>> /**
>>> @@ -135,7 +134,7 @@
>>> * @return possible object is
>>> * {_at_link String }
>>> */
>>> - @Attribute
>>> + @Attribute (defaultValue="true")
>>> public String getEnabled();
>>> /**
>>>
>>> Modified: trunk/v3/admin/config-api/src/main/java/com/sun/
>>> enterprise/config/serverbeans/AdminService.java
>>> Url: https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/AdminService.java?view=diff&rev=18837&p1=trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/AdminService.java&p2=trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/AdminService.java&r1=18836&r2=18837
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ====================================================================
>>> --- trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/
>>> config/serverbeans/AdminService.java (original)
>>> +++ trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/
>>> config/serverbeans/AdminService.java 2008-03-14 06:02:57+0000
>>> @@ -45,7 +45,6 @@
>>> import org.jvnet.hk2.component.Injectable;
>>> import java.beans.PropertyVetoException;
>>> -import java.io.Serializable;
>>> import java.util.List;
>>> @@ -66,7 +65,7 @@
>>> * @return possible object is
>>> * {_at_link String }
>>> */
>>> - @Attribute
>>> + @Attribute (defaultValue="server")
>>> public String getType();
>>> /**
>>>
>>> Added: trunk/v3/admin/config-api/src/test/java/com/sun/enterprise/
>>> configapi/tests/dvt/AccessLogAllDefaultsTest.java
>>> Url: https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/admin/config-api/src/test/java/com/sun/enterprise/configapi/tests/dvt/AccessLogAllDefaultsTest.java?view=auto&rev=18837
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ====================================================================
>>> --- (empty file)
>>> +++ trunk/v3/admin/config-api/src/test/java/com/sun/enterprise/
>>> configapi/tests/dvt/AccessLogAllDefaultsTest.java 2008-03-14
>>> 06:02:57+0000
>>> @@ -0,0 +1,50 @@
>>> +/*
>>> + * To change this template, choose Tools | Templates
>>> + * and open the template in the editor.
>>> + */
>>> +
>>> +package com.sun.enterprise.configapi.tests.dvt;
>>> +
>>> +import com.sun.enterprise.config.serverbeans.AccessLog;
>>> +import com.sun.enterprise.configapi.tests.ConfigApiTest;
>>> +import java.beans.PropertyVetoException;
>>> +import org.junit.After;
>>> +import org.junit.Before;
>>> +import org.junit.Test;
>>> +import static org.junit.Assert.*;
>>> +
>>> +/**
>>> + *
>>> + * @author kedar
>>> + */
>>> +public class AccessLogAllDefaultsTest extends ConfigApiTest {
>>> +
>>> + private AccessLog al = null;
>>> + + public AccessLogAllDefaultsTest() {
>>> + }
>>> + + @Override
>>> + public String getFileName() {
>>> + return ("AccessLogAllDefaultsTest"); //this is the xml to
>>> load
>>> + }
>>> + + @Before
>>> + public void setUp() {
>>> + al = super.getHabitat().getComponent(AccessLog.class);
>>> + }
>>> +
>>> + @After
>>> + public void tearDown() {
>>> + al = null;
>>> + }
>>> + @Test + public void testAllDefaults() {
>>> + assertEquals("%client.name% %auth-user-name% %datetime%
>>> %request% %status% %response.length%",
>>> + al.getFormat());
>>> + assertEquals("true", al.getRotationEnabled());
>>> + assertEquals("1440", al.getRotationIntervalInMinutes());
>>> + assertEquals("time", al.getRotationPolicy());
>>> + assertEquals("yyyyMMdd-HH'h'mm'm'ss's'",
>>> al.getRotationSuffix());
>>> + }
>>> +}
>>> \ No newline at end of file
>>>
>>> Modified: trunk/v3/admin/config-api/src/test/java/com/sun/
>>> enterprise/configapi/tests/dvt/JdbcConnectionPoolDefaultsTest.java
>>> Url: https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/admin/config-api/src/test/java/com/sun/enterprise/configapi/tests/dvt/JdbcConnectionPoolDefaultsTest.java?view=diff&rev=18837&p1=trunk/v3/admin/config-api/src/test/java/com/sun/enterprise/configapi/tests/dvt/JdbcConnectionPoolDefaultsTest.java&p2=trunk/v3/admin/config-api/src/test/java/com/sun/enterprise/configapi/tests/dvt/JdbcConnectionPoolDefaultsTest.java&r1=18836&r2=18837
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ====================================================================
>>> --- trunk/v3/admin/config-api/src/test/java/com/sun/enterprise/
>>> configapi/tests/dvt/JdbcConnectionPoolDefaultsTest.java
>>> (original)
>>> +++ trunk/v3/admin/config-api/src/test/java/com/sun/enterprise/
>>> configapi/tests/dvt/JdbcConnectionPoolDefaultsTest.java
>>> 2008-03-14 06:02:57+0000
>>> @@ -61,13 +61,6 @@
>>> public String getFileName() {
>>> return ("JdbcConnectionPoolDefaults"); //this is the xml
>>> to load
>>> }
>>> - @BeforeClass
>>> - public static void setUpClass() throws Exception {
>>> - }
>>> -
>>> - @AfterClass
>>> - public static void tearDownClass() throws Exception {
>>> - }
>>> @Before
>>> public void setUp() {
>>>
>>> Added: trunk/v3/admin/config-api/src/test/resources/
>>> AccessLogAllDefaultsTest.xml
>>> Url: https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/admin/config-api/src/test/resources/AccessLogAllDefaultsTest.xml?view=auto&rev=18837
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ====================================================================
>>> --- (empty file)
>>> +++ trunk/v3/admin/config-api/src/test/resources/
>>> AccessLogAllDefaultsTest.xml 2008-03-14 06:02:57+0000
>>> @@ -0,0 +1,2 @@
>>> +<?xml version="1.0" encoding="UTF-8"?>
>>> +<access-log/>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: commits-unsubscribe_at_glassfish-svn.dev.java.net
>>> For additional commands, e-mail: commits-help_at_glassfish-svn.dev.java.net
>>>
>>>
>