I haven't read the CLIP guidelines for a while, but I think accepting
mis-spellings is likely to raise eyebrows at the very least. Case-
insensitive is probably fine, and desirable IMO.
I do agree that an error message would be in order...is the matching
algorithm to make a Set of the characters of the option and see if it
matches a significant number of characters from other option names?
Lloyd
On Feb 12, 2008, at 12:06 PM, Kedar Mhaswade wrote:
>
>
> Jerome Dochez wrote:
>> I was talking to Jane about this yesterday, We need to ensure we
>> are satisfying the CLIP requirements but that's definitely my
>> feeling too,
>> just like if someone types --contxetroot, we should interpret it
>> as --contextroot...
>
>
> Hmm. That's interesting but difficult to get right and has
> implications
> on "interface" definition and compatibility.
> Maybe someone did want to get an error back
> on typo? (Otherwise we might have to support all the typos forever!)
>
> Case-sensitivity is slightly different. For a long option, a "correct"
> spelling in any case could be accepted as valid without huge (as in
> difficult to deal with) implications.
>
> Incidentally, I think we need to consider the exit codes from CLI with
> some seriousness. I have started a discussion topic at:
> http://wiki.glassfish.java.net/Wiki.jsp?
> page=ProsAndConsOfAsadminExitCodes
> and will be adding content to it soon. A reasonable exit code (and
> message)
> would indicate the typo like: "Did you mean --contextroot instead"?
> would
> lead to better overall user experience.
>
> Regards,
> Kedar
>
>> jerome
>> On Feb 12, 2008, at 11:13 AM, Kedar Mhaswade wrote:
>>>
>>>
>>> Amy Roh wrote:
>>>> Right. I had to change it to be compatible with v2 option and
>>>> to run some of the devtests which depended on it. Not sure why
>>>> it was contextRoot initially in v3.
>>>> +1 on case-insensitiveness of the option names
>>>
>>> I agree. It is more user-friendly to make "long" option-names
>>> case-insensitive. Short-options on the other hand, need to be
>>> case-sensitive.
>>>
>>> - Kedar
>>>
>>>> Thanks,
>>>> Amy
>>>> Hong Zhang wrote:
>>>>> Ok, thanks Vince. From a quick look of Pramod's email, I
>>>>> thought we were changing to something different than v2. :-P
>>>>> In v3, we would probably also support the case-insensitiveness
>>>>> of the option names in addition to maintain the backward
>>>>> compatibility.
>>>>>
>>>>> - Hong
>>>>>
>>>>> Vince Kraemer wrote:
>>>>>> I think the admin cli uses "contextroot" in v2... That is what
>>>>>> it says on the "man page" for asadmin deploy....
>>>>>>
>>>>>> So, I think Amy's check in makes v3 more compatible with v2...
>>>>>>
>>>>>> vbk
>>>>>>
>>>>>> Hong Zhang wrote:
>>>>>>> Hi, Amy
>>>>>>> Is there any particular reason that you need to change this
>>>>>>> option name? We need to keep backward compatibility for admin
>>>>>>> cli options.
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> - Hong
>>>>>>>
>>>>>>> Jane Young wrote:
>>>>>>>> Yes, --contextRoot option is now --contextroot.
>>>>>>>> See Amy's check-ins:
>>>>>>>> https://glassfish-svn.dev.java.net/source/browse/glassfish-
>>>>>>>> svn/trunk/v3/core/kernel/src/main/java/com/sun/enterprise/v3/
>>>>>>>> deployment/DeployCommand.java?view=diff&rev=17924&p1=trunk/
>>>>>>>> v3/core/kernel/src/main/java/com/sun/enterprise/v3/
>>>>>>>> deployment/DeployCommand.java&p2=trunk/v3/core/kernel/src/
>>>>>>>> main/java/com/sun/enterprise/v3/deployment/
>>>>>>>> DeployCommand.java&r1=17923&r2=17924
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Pramod Gopinath wrote:
>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>> Wanted to check if the asadmin deploy command had changed
>>>>>>>>> recently w.r.t how one specifies the context root where one
>>>>>>>>> wants the application to be deployed.
>>>>>>>>>
>>>>>>>>> In some prior version I thought I used --contextRoot as the
>>>>>>>>> option, whereas lately I need to use --contextroot.
>>>>>>>>>
>>>>>>>>> Am I mistaken and was it always --contextroot.
>>>>>>>>>
>>>>>>>>> Just checking a doubt.
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>> Pramod
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --------------------------------------------------------------
>>>>>>>>> -------
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>>>>> For additional commands, e-mail: dev-
>>>>>>>>> help_at_glassfish.dev.java.net
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------
>>>>>>>> ------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>>>> For additional commands, e-mail: dev-
>>>>>>>> help_at_glassfish.dev.java.net
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ----------------------------------------------------------------
>>>>>>> -----
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>>
>>>>>>
>>>>>>
>>>>>> -----------------------------------------------------------------
>>>>>> ----
>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------
>>>>> ---
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>> -------------------------------------------------------------------
>>>> --
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>> --------------------------------------------------------------------
>>> -
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>
---
Lloyd L Chambers
lloyd.chambers_at_sun.com
Sun Microsystems, Inc