dev@glassfish.java.net

Re: CVS update: /glassfish/appserv-commons/src/java/com/sun/enterprise/deployment/io/

From: Dinesh Patil <Dinesh.Patil_at_Sun.COM>
Date: Mon, 29 Jan 2007 13:34:41 -0800

Build is broken due to this, pls look into this quickly.

   [java] init:
    [java] [echo] Building component appserv-commons
    [java] [mkdir] Created dir: /Users/matrix/work/Darwin_8.8.0_depend/workspace/glassfish/appserv-commons/build
    [java]
    [java] compile:
    [java] [javac] Compiling 779 source files to /Users/matrix/work/Darwin_8.8.0_depend/workspace/glassfish/appserv-commons/build
    [java] [javac] /Users/matrix/work/Darwin_8.8.0_depend/workspace/glassfish/appserv-commons/src/java/com/sun/enterprise/deployment/io/DeploymentDescriptorFile.java:329: cannot find symbol
    [java] [javac] symbol : method setCause(java.io.IOException)
    [java] [javac] location: class java.io.IOException
    [java] [javac] ioe.setCause(e);
    [java] [javac] ^
    [java] [javac] Note: Some input files use or override a deprecated API.
    [java] [javac] Note: Recompile with -Xlint:deprecation for details.
    [java] [javac] Note: Some input files use unchecked or unsafe operations.
    [java] [javac] Note: Recompile with -Xlint:unchecked for details.
    [java] [javac] 1 error
    [java]


tjquinn_at_dev.java.net wrote:

>User: tjquinn
>Date: 2007/01/29 12:45:24
>
>Modified:
> glassfish/appserv-commons/src/java/com/sun/enterprise/deployment/io/DeploymentDescriptorFile.java
> glassfish/appserv-commons/src/java/com/sun/enterprise/deployment/io/LocalStrings.properties
>
>Log:
> Fix for issue 1231 - appclient fail in one cmp unit test and error message not very helpful
>
> One CMP unit test failed in the app client. The problem was that the generated app client JAR file refers (in the application.xml) to alternate deployment descriptors for submodules, including a web submodule as in this unit test. The code was correctly omitting the web submodule from the app client JAR but was also excluding the alternate deployment descriptor. The application.xml still referred to the alternate descriptor, so the ACC could not load the app client JAR because of the missing file.
>
> The fix - the lowest-impact fix available - is to include alternate descriptors that would normally be excluded from the generated app client JAR files, even though the ACC does not actually need their contents. This allows the archivist on the client to load the app client JAR successfull because it can now locate the alternate descriptor files.
>
>
> Reviewed by: Hong
> Also, pre-check-in patch verified by Marina (thanks)
>
>
> Tests:
>
> deployment dev tests; SQE quick-looks; Marina's separate run of the failing unit test
>
>
> Code changes:
>
> appserv-commons/src/java/com/sun/enterprise/deployment/io
> DeploymentDescriptorFile.java
> LocalStrings.properties
>
> appserv-core/src/java/com/sun/enterprise/deployment/backend
> ApplicationClientJarMaker.java
>
>File Changes:
>
>Directory: /glassfish/appserv-commons/src/java/com/sun/enterprise/deployment/io/
>================================================================================
>
>File [changed]: DeploymentDescriptorFile.java
>Url: https://glassfish.dev.java.net/source/browse/glassfish/appserv-commons/src/java/com/sun/enterprise/deployment/io/DeploymentDescriptorFile.java?r1=1.10&r2=1.11
>Delta lines: +6 -2
>-------------------
>--- DeploymentDescriptorFile.java 11 Aug 2006 17:19:06 -0000 1.10
>+++ DeploymentDescriptorFile.java 29 Jan 2007 20:45:21 -0000 1.11
>@@ -299,7 +299,7 @@
> return null;
> } catch (IOException e) {
> DOLUtils.getDefaultLogger().log(Level.SEVERE, "enterprise.deployment.backend.saxParserError",
>- new Object[]{e.getMessage()});
>+ e.getMessage() == null ? "" : new Object[]{e.getMessage()});
>
> // Let's check if the root cause of this IOException is failing to
> // connect. If yes, it means two things:
>@@ -323,7 +323,11 @@
> }
> }
>
>- throw e;
>+ IOException ioe = new IOException(localStrings.getLocalString(
>+ "enterprise.deployment.backend.error_parsing_descr",
>+ "Error parsing descriptor: {0}", new Object[] {errorReporting}));
>+ ioe.setCause(e);
>+ throw ioe;
> }
> if (dh.getTopNode()!=null) {
> Object topDesc = dh.getTopNode().getDescriptor();
>
>File [changed]: LocalStrings.properties
>Url: https://glassfish.dev.java.net/source/browse/glassfish/appserv-commons/src/java/com/sun/enterprise/deployment/io/LocalStrings.properties?r1=1.3&r2=1.4
>Delta lines: +1 -0
>-------------------
>--- LocalStrings.properties 11 Aug 2006 17:19:06 -0000 1.3
>+++ LocalStrings.properties 29 Jan 2007 20:45:21 -0000 1.4
>@@ -1,3 +1,4 @@
> enterprise.deployment.io.errorloadingdds=Error while parsing {0}
> enterprise.deployment.io.errorcontext=Deployment descriptor file {1} in archive [{0}].
> enterprise.deployment.can_not_locate_dtd=Unable to locate the DTD to validate your deployment descriptor file [{1}] in archive [{0}]. Please make sure the DOCTYPE is correct (no typo in public ID or system ID) and you have proper access to the Internet.
>+enterprise.deployment.backend.error_parsing_descr=Error parsing descriptor {0}
>\ No newline at end of file
>
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: cvs-unsubscribe_at_glassfish.dev.java.net
>For additional commands, e-mail: cvs-help_at_glassfish.dev.java.net
>
>
>