QuickLook spends MOST of its time sleeping on my machine.
We need to improve the speed with which QuickLook runs. Here are
some proposed changes. I am not familiar with why or when these
values were chosen.
I am also not certain of the implications of reducing these values
for machines other than my development machine. But I also don't
like having to wait 7 extra minutes (more if PE and EE are run) just
for a dozing test suite.
Surely there is a better way to do this which will save *everyone*
much time?
At the very least, I would like to see ALL sleep times centralized
into a single properties file, so that I can quickly whack the values
to much smaller ones. Below are diffs of various places in which
everyone's time is being wasted needlessly (on many machines at least).
Lloyd
MB2:/gf/build/glassfish/appserv-tests lloyd$ cvs diff
Index: sqetests/ejb/bmp/enroller/build-ng.xml
===================================================================
RCS file: /cvs/glassfish/appserv-tests/sqetests/ejb/bmp/enroller/
build-ng.xml,v
retrieving revision 1.1
diff -r1.1 build-ng.xml
130c130
< <sleep minutes="2"/>
---
> <sleep minutes="1"/>
Index: sqetests/ejb/bmp/enroller/build.xml
===================================================================
RCS file: /cvs/glassfish/appserv-tests/sqetests/ejb/bmp/enroller/
build.xml,v
retrieving revision 1.1.1.1
diff -r1.1.1.1 build.xml
126c126
< <sleep minutes="2"/>
---
> <sleep minutes="1"/>
cvs server: Diffing sqetests/ejb/bmp/enroller/client
cvs server: Diffing sqetests/ejb/bmp/enroller/descriptor
cvs server: Diffing sqetests/ejb/bmp/enroller/ejb
cvs server: Diffing sqetests/ejb/bmp/enroller/sql
cvs server: Diffing sqetests/ejb/bmp/enroller/testng-client
cvs server: Diffing sqetests/ejb/bmp/robean
Index: sqetests/ejb/bmp/robean/build.xml
===================================================================
RCS file: /cvs/glassfish/appserv-tests/sqetests/ejb/bmp/robean/
build.xml,v
retrieving revision 1.1.1.1
diff -r1.1.1.1 build.xml
109c109
< <sleep minutes="2"/>
---
> <sleep minutes="1"/>
cvs server: Diffing sqetests/ejb/bmp/robean/client
Index: sqetests/ejb/bmp/robean/client/ROBClient.java
===================================================================
RCS file: /cvs/glassfish/appserv-tests/sqetests/ejb/bmp/robean/client/
ROBClient.java,v
retrieving revision 1.1.1.1
diff -r1.1.1.1 ROBClient.java
188,190c188,191
<
< System.out.println("Sleeping for 80 seconds");
< Thread.sleep(80000);
---
>
> final long sleepSeconds = 10;
> System.out.println("Sleeping for " + sleepSeconds + "
seconds");
> Thread.sleep( sleepSeconds );
cvs server: Diffing sqetests/ejb/bmp/robean/descriptor
Index: sqetests/ejb/stateful/passivate/client/SessionTestClient.java
===================================================================
RCS file: /cvs/glassfish/appserv-tests/sqetests/ejb/stateful/
passivate/client/SessionTestClient.java,v
retrieving revision 1.1.1.1
diff -r1.1.1.1 SessionTestClient.java
98,99c98,101
< System.out.println("Now going to sleep for 40 secs to
passivate beans");
< Thread.sleep(40000);
---
>
> final long sleepSeconds = 5;
> System.out.println("Now going to sleep for " +
sleepSeconds + " secs to passivate beans");
> Thread.sleep( sleepSeconds * 1000 );