dev@glassfish.java.net

Re: EjbWebServiceServlet - unused dispather

From: Jan Luehe <Jan.Luehe_at_Sun.COM>
Date: Mon, 13 Mar 2006 15:23:13 -0800

Hi Mark,

Mark Hansen wrote On 03/13/06 15:03,:

> I'm just poking around the code an noticed that the
> com.sun.enterprise.webservice.EjbWebServiceServlet class constructor
> creates an instance of EjbWebServiceDispatcher that is never used. I
> thought that one of the developers might want to look at that.


you're right! I believe the "webServiceDispatcher" instance var was
left over from an earlier impl approach.

I'm about to commit this patch:

Index: EjbWebServiceServlet.java
===================================================================
RCS file:
/cvs/glassfish/appserv-core/src/java/com/sun/enterprise/webservice/EjbWebServiceServlet.java,v
retrieving revision 1.9
diff -u -r1.9 EjbWebServiceServlet.java
--- EjbWebServiceServlet.java 10 Mar 2006 04:22:15 -0000 1.9
+++ EjbWebServiceServlet.java 13 Mar 2006 23:21:07 -0000
@@ -73,19 +73,8 @@
     private static final Base64 base64Helper = new Base64();
     private static final String AUTHORIZATION_HEADER = "authorization";

- private EjbWebServiceDispatcher webServiceDispatcher;
-
     private static AuditManager auditManager =
             AuditManagerFactory.getAuditManagerInstance();
-
-
- /*
- * Constructor
- */
- public EjbWebServiceServlet() {
- webServiceDispatcher = new EjbWebServiceDispatcher();
- }
-

     protected void service(HttpServletRequest hreq, HttpServletResponse
hresp)
             throws ServletException, IOException {


Thanks!


Jan


>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>