dev@glassfish.java.net

[Fwd: Workspace cleanup]

From: Jerome Dochez <Jerome.Dochez_at_Sun.COM>
Date: Thu, 27 Oct 2005 15:05:06 -0700

attached mail follows:



Module-owners :

I briefly broke the build earlier today because some module's "maven
clean" are not cleaning up tidily which meant that code was not being
recompiled as expected.

So last month, I discovered that "maven clean build" would not stop at
compilation errors in sub modules. Today I discover that "maven clean ;
maven build" from the appserv directory is not a guarantee that all
classes and jar are being rebuild. Why does it only happen to me ;-)

Anyhow, I quickly looked at a fresh checkout workspace versus a
workspace that was built at least once and a "maven clean" was ran from
"appserv". In theory, those two should be equals.

And I found that in the "clean" workspace, the following .class files
are NOT cleaned

./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/AttrAddress.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/AttrType.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/ValidationContext.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/Result.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/ValidationDescriptor.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/NameListMgr.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/DomainMgr.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/NameList.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/GenericValidator.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/DomainCheck.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/AttrClassName.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/AttrFile.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/AttrInt.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/AttrString.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/AttrUniqueJNDI.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/DomainXmlVerifier.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/Frame$1.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/AdminObjectResourceTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/AuthRealmTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/ClusterTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/ConnectorConnectionPoolTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/ConnectorModuleTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/DeployableAppTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/DomainTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/EjbModuleTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/HttpListenerTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/J2eeApplicationTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/JavaConfigTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/JdbcConnectionPoolTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/JmsHostTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/JvmOptionsTest$InvalidJvmOptionsException.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/JvmOptionsTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/LifecycleModuleTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/ProfilerTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/ProviderConfigTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/ServerTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/SslTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/StaticTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/VirtualServerTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/WebModuleTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/tests/WebServiceEndpointTest.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/Frame.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/FrameHolder.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/FrameHolderBuilder.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/Framer.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/GenericDesc.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/Localiser.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/RNGValidator$MyErrorHandler.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/RNGValidator.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/Schematron.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/StringManagerHelper.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/VariableExpander.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/VariableResolver$1.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/VariableResolver.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/XMLReaderFactory$MyErrorHandler.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/XMLReaderFactory.class
./admin/validator/build/com/sun/enterprise/config/serverbeans/validation/XPathHelper.class
./tools/ddgenerator/build/com/sun/enterprise/ddgenerator/sun/Application.class
./tools/ddgenerator/build/com/sun/enterprise/ddgenerator/sun/DescriptorArchivist.class
./tools/ddgenerator/build/com/sun/enterprise/ddgenerator/sun/EjbModule.class

that's including the last three files that got me in RED...

and the following JAR files are NOT removed

./cmp/generator/database/jars/persistence-generator-database.jar
./cmp/mapping/ejb/jars/persistence-mapping-ejb.jar
./cmp/support/jars/locale/persistence-rt_ja.jar
./cmp/support/jars/persistence-rt.jar
./appserv-core/misc/ejbtimer/ejb.jar
./admin-core/jsr77/src/java/com/sun/enterprise/management/agent/mejb.jar


while we are at it, I also saw the following JAR files are checked in
the source workspace. Is this really necessary ?

./servlet-api/src/jakarta-servletapi-5/jsr152/examples/WEB-INF/lib/standard.jar
./servlet-api/src/jakarta-servletapi-5/jsr152/examples/WEB-INF/lib/jstl.jar
./servlet-api/src/jsr245/examples/WEB-INF/lib/standard.jar
./servlet-api/src/jsr245/examples/WEB-INF/lib/jstl.jar
./admin-core/config-api/internal/config_gen/dtdformatter.jar
./admin-core/config-api/internal/config_gen/s2b.jar
./admin-core/config-api/src/xsl/schematron/xalan.jar
./admin/mbeanapi-impl/tests/javax77.jar
./admin/mbeanapi-impl/tests/junit.jar
./cmp/release/build/nbantext.jar
./tools/src/java/com/sun/enterprise/tools/deployment/main/make/deployhelp.jar
./tools/src/java/com/sun/enterprise/tools/verifier/config/verifierhelp.jar
./admin-gui/framework/src/java/com/sun/enterprise/tools/guiframework/lockhart/lib/registrationservlet.jar