I agree with Anissa. When I'm trying to document the domain.xml
defaults, it becomes rather tricky when there are two defaults in two
different places. It almost defeats the purpose of having a default in
the first place.
Rebecca
On 11/10/10 08:29, Anissa Lam wrote:
>
> My original thinking was that, both the OOTB value and default value
> are just inherited from v2. As to why v2 needs this to be different, i
> don't know.
> Regarding not being able to 'see' the value in domain.xml and thus can
> be easily edited in 'vi' is generic for every attribute. I don't see
> why we need to treat these attributes differently.
> I think we should just decide what we really want to be the default and
> OOTB value and fix that (if needed to) without worrying whether the
> value will show up in domain.xml or not. Just my 2 cents.
>
> Anissa.
>
> On 11/10/10 8:06 AM, Tim Quinn wrote:
>> I am not sure why the autodeploy directory does not match. It might
>> have been the same rationale as the others...
>>
>> I am not positive, but IIRC the others might have been set up to
>> differ - dynamic-reload-enabled and autodeploy-enabled - for this
>> reason: The hk2 config implementation suppresses the XML output if
>> the value matches the default. Yet users were accustomed to editing
>> domain.xml to turn these off or on. If the out-of-the-box values
>> matched the defaults then the attributes did not appear in the element
>> - and maybe the element itself didn't appear?? (not so sure about that
>> part). So to "force" maybe the element and definitely the attribute
>> to appear so users could see what to edit more easily the OOTB and the
>> default values were set differently.
>>
>> I am fairly sure that we the thinking at least at one point. Whether
>> we want to continue that way is a separate question.
>>
>> - Tim
>>
>> On Nov 10, 2010, at 9:50 AM, Tom Mueller wrote:
>>
>>> This is regarding issue 14557.
>>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=14557
>>>
>>> The "das-config" values in the out-of-the-box domain.xml do not match
>>> the default values in the DasConfig.java file for the following
>>> properties:
>>> dynamic-reload-enabled: default false, domain.xml template: true
>>>
>>> autodeploy-enabled: default false, domain.xml template: true
>>> autodeploy-dir: default "autodeploy", domain.xml template:
>>> ="${com.sun.aas.instanceRoot}/autodeploy"
>>>
>>> Does anyone know the background behind this?
>>> Is there a reason why the defaults are different than what we ship in the domain.xml template?
>>>
>>>
>>> Where this shows up is that in the admin console, there is a "Load
>>> Defaults" button, which loads the defaults from the DasConfig.java
>>> file, not the values from the original domain.xml template.
>>>
>>> Thanks.
>>> Tom
>>>
>>>
>>