Reminds me of the story about the newlywed who cut off the end of the
roast
<
http://mikeschinkel.com/blog/conventionalwisdomassumptionsandpotroast/>. :-)
Based on looking at the svn history, neither the DasConfig.java nor the
domain.xml template file were changed in this area in a very long time
(April 2008 for DasConfig, and never in the current SVN for domain.xml).
I had thought the change to the way the domain.xml was written occurred
during the development of 3.1.
Tom
On 11/10/2010 10:06 AM, Tim Quinn wrote:
> I am not sure why the autodeploy directory does not match. It might
> have been the same rationale as the others...
>
> I am not positive, but IIRC the others might have been set up to
> differ - dynamic-reload-enabled and autodeploy-enabled - for this
> reason: The hk2 config implementation suppresses the XML output if
> the value matches the default. Yet users were accustomed to editing
> domain.xml to turn these off or on. If the out-of-the-box values
> matched the defaults then the attributes did not appear in the element
> - and maybe the element itself didn't appear?? (not so sure about that
> part). So to "force" maybe the element and definitely the attribute
> to appear so users could see what to edit more easily the OOTB and the
> default values were set differently.
>
> I am fairly sure that we the thinking at least at one point. Whether
> we want to continue that way is a separate question.
>
> - Tim
>
> On Nov 10, 2010, at 9:50 AM, Tom Mueller wrote:
>
>> This is regarding issue 14557.
>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=14557
>>
>> The "das-config" values in the out-of-the-box domain.xml do not match
>> the default values in the DasConfig.java file for the following
>> properties:
>> dynamic-reload-enabled: default false, domain.xml template: true
>> autodeploy-enabled: default false, domain.xml template: true
>> autodeploy-dir: default "autodeploy", domain.xml template:
>> ="${com.sun.aas.instanceRoot}/autodeploy"
>>
>> Does anyone know the background behind this?
>> Is there a reason why the defaults are different than what we ship in the domain.xml template?
>>
>> Where this shows up is that in the admin console, there is a "Load
>> Defaults" button, which loads the defaults from the DasConfig.java
>> file, not the values from the original domain.xml template.
>>
>> Thanks.
>> Tom
>>
>>
>