Well, you're right, it's probably not going to be used, but it seems better
to rename it and clean it up than to let it sit around unused and potentially
confuse people.
It is weird that the directory is per-installation but the renaming is done
when starting each domain. Hopefully no one is storing v2 domains/nodes in
a v3 installation directory.
Tom Mueller wrote on 08/12/2010 07:01 AM:
> Bill,
> Do we use the nodeagents directory in the upgrade case?
>
> With our strategy being to upgrade the domain.xml, recreate all of the
> instances, and synchronize, the only use for the old nodeagents area is
> for the user to copy over application-specific per-instance data (if
> there is any) and that would have to be a manual procedure.
>
> Tom
>
>
> On 8/11/2010 10:06 PM, Bill Shannon wrote:
>> Joe Di Pol wrote on 08/11/2010 03:41 PM:
>>>
>>> I'm looking for a couple of eyeballs to take a quick look at this
>>> since it is fairly wide-ranging. The fix is for:
>>>
>>> Rename "nodeagents" dir to "nodes"
>>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=12640
>>>
>>> This changes the name of the "nodeagents" directory to "nodes".
>>> I've grep'd the source and changed all occurrences that seemed
>>> relevant. I've run quicklook and the admin dev tests and so
>>> far all is well (I did need to modify a couple dev tests -- those
>>> changes are not included here).
>>>
>>> The change is pretty boring -- what I'm really looking for
>>> is if there is anything obvious that I've missed.
>>
>>
>> There were several field and method names that could've been renamed to
>> remove the "agent" part, e.g., "agentsDir" -> "nodesDir". Extra credit
>> if you fix those.
>>
>> The only real issue is that I didn't see the code that would handle the
>> upgrade case and rename the directory.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>