Hi Joe,
Not sure if this needs to go the @Supplemental route. But the code looks good to me.
Thanks
Sheetal
On Jul 27, 2010, at 8:43 AM, Joseph Fialli wrote:
> All,
>
> During the GMS arch review, I asked whether it would be appropriate to use @Supplemental
> or to just place calls to appropriate GMS API directly into the StartClusterCommand to achieve this.
> No one knew the correct answer for my description so we settled on the approach of
> coding it inline to illustrate what needed to be done.
> These GMS APIs existed in glassfish v2.1 and were called in the serverbean that managed
> start-cluster.
>
> The end result was I have put together what needs to be done directly in StartClusterCommand.java.
> I have attached those changes and corresponding pom.xml changes needed.
> This code is tested to work (and needed for me to be able to close glassfish issue tracker 12730)
> The code is written to work if gms is not enabled in any cluster that is in domain.xml
> AND if gms is not enabled for cluster that is being started.
>
> If it is more appropriate for this functionality to be done with @Supplemental, we will do it that way.
> This review request was intended to illustrate what needs to be done.
> (Note: we are not open to changing the SHOAL GMS api for announceGroupStartup().
> These methods existed in previous versions of GMS (and worked in Glassfish v2.1 as is).)
>
> Note that a similar change needs to be done for StopClusterCommand calling gms announceGroupShutdown().
>
> There is outstanding todos in submitted code:
> 1. on gettting the failed instance names out of the ActionReport //unsure if this is accessible or not from @Supplemental
> 2. enhance logger.warning messages // will change if code is moved to @Supplemental. So it is minimal effort at this point.
>
> -Joe
> <supplementalgmsstartcluster.dif>---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net