admin@glassfish.java.net

Re: review request for admingui submodules' pom.xml

From: Jane Young <jane.young_at_oracle.com>
Date: Mon, 21 Jun 2010 13:08:23 -0700

Looks good. One suggestion, you may want to define the plugin in
v3/pom.xml's pluginManangement element
               
<plugin>

                    
<groupId>org.apache.maven.plugins</groupId>

                    
<artifactId>maven-clean-plugin<</artifactId>

                    
<version>2.4.1</version>

                
</plugin>

This is so that the version is defined in one central location. In the
submodule pom files, remove the version element.
                                                                                                            

Also, several files have "^M". Can you fix it before committing?

Thanks,
Jane

Anissa Lam wrote:
>
> Hi Jane,
> I have modified the admingui sub-modules pom.xml to add
> maven-clean-plugin as you suggested. I have tested and it works as
> expected.
> Please review and let me know if i can checkin.
>
> thanks
> Anissa.
>