On 5/14/2010 12:56 PM, Bhakti Mehta wrote:
> Hi,
> I wanted to give a status on create-cluster. Jerome had a lot of the
> GenericCRUDCommands infrastructure in place so that give me an
> opportunity to learn about it and fix minor bugs.
>
> 1. There is --config option and not config-ref in create-cluster so
> fixed that
> 2. Fixed the system-properties that were not showing up right in the
> cluster and server elements.
> 3.Done some validations in case the config does not exist, or
> server/config/cluster should not have same names. ( I added newer
> ducktypes in Domain and have modified Server.java too)
>
> Should there be a validation to not allow any other system properties
> except these?
> HTTP_LISTENER_PORT
> HTTP_SSL_LISTENER_PORT
> IIOP_LISTENER_PORT
> IIOP_SSL_LISTENER_PORT
> IIOP_SSL_MUTUALAUTH_PORT
> JMX_SYSTEM_CONNECTOR_PORT
No. They can put anything they like in here.
>
> http://wiki.glassfish.java.net/Wiki.jsp?page=V3.1Clustering#section-V3.1Clustering-CreateCluster
> mentions about portbase but I am assuming we are not going to support
> it since we are not supporting any hadb options. The --help version
> lists all options along with Hadb shouldnt those be removed if we are
> not supporting them?
Yes they should be removed
>
> I have tested with passwordfile (nonexistent and incorrect password).
>
> The next step will be to add automated tests for these in some
> framework we agree upon.
> Please can you comment on the above questions and let me know if I
> need to add more validations or move on to another task and testing?
>
> Regards,
> Bhakti
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>
--
Byron Nevins - Oracle Corporation
Home: 650-359-1290
Cell: 650-784-4123
Sierra: 209-295-2188