Thanks for reviewing. I'll change the default value to "5000" for
ping-protocol-timeout-in-millis in the config bean.
On 4/6/2010 10:56 PM, Joseph Fialli wrote:
> Jennifer,
>
> Find a review comment from the GMS group below relating to changes to
> default-config.xml.
>
> On 4/6/10 12:57 PM, Jennifer Chou wrote:
>> Here's the review notes from last week:
>> http://wiki.glassfish.java.net/Wiki.jsp?page=ServerConfig_vs_defaultConfig
>>
>> and draft 2 of 3.1 default-config template, with review updates,
>> items to be removed, and differences in attributes values
>> http://wiki.glassfish.java.net/attach/ServerConfig_vs_defaultConfig/31default-config.xml_with_notes-2.html
> Comments for group-management-service atttribute
> ping-protocol-timeout-in-millis.
>
> <group-management-service ping-protocol-timeout-in-millis="5000"/>
> (Remove attributes with default values)
> v2: ping-protocol-timeout-in-millis="5000"
> v3 default value: ping-protocol-timeout-in-millis="2000"
>
>
> ping-protocol-timeout-in-millis maps to Shoal property DISCOVERY_TIMEOUT.
> It is best if it maps to the v2 value of "5000" milliseconds in v3 by
> default.
>
> I realize that the default of "2000" was probably obtained from the
> following v2.1.1 source code, the shoal code default is proper at 5000
> millis.
>
> admin-core/config-api/src/java/com/sun/enterprise/config/serverbeans/GroupManagementService.java
>
> /**
> * Get the default value of PingProtocolTimeoutInMillis from dtd
> */
> public static String getDefaultPingProtocolTimeoutInMillis() {
> return "2000".trim();
> }
>
> Thanks,
>
> -Joe Fialli
>
>
>>
>> On 4/6/2010 5:44 PM, Byron Nevins wrote:
>>>
>>> http://wiki.glassfish.java.net/Wiki.jsp?page=AdminIteam
>>>
>>> Tuesdays 3PM PDT
>>> Room: It's A Small World, SCA 14, 3rd floor, 3385
>>> (866)545-5227
>>> (215)446-3648 (International-Caller Paid)
>>> Access Code: 3535518#
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>
>>
>> --
>> Thanks, Jennifer x81033 (440-709-5095)
>>
>> Oracle <http://www.oracle.com>
>> Jennifer Chou
>> Phone: +1 44 20 7409 7350 <tel:+1%2044%2020%207409%207350> | Mobile:
>> +1 44 755 283 8283 <tel:+1%2044%20755%20283%208283>
>> | London, England
>> Green Oracle <http://www.oracle.com/commitment> Oracle is committed
>> to developing practices and products that help protect the environment
>>
>>