Hi Paul,
Thanks for doing this. Here are some comments:
0- Please change "This command replaces the traditional
techniques like sending ctrl+break or kill -3 signals to application server
processes" to say "This works in addition to traditional techniques like
sending kill -3 signal to server process, which might be the only way to
get the thread dump in cases of hung processes". Thus, this particular
command is designed for monitoring and improving serviceability aspects of
the server process.
1- Mention somewhere that "summary" is the default for --type.
Thus, if you don't specify --type, a summary will be reported.
2- Please mention somewhere that if the JRE which GlassFish runs atop
is JDK 6 (or JRE 6), we can get additional information from the report.
If this information is not available on the given JRE (JDK) atop which
server runs, it will be reported as NOT_AVAILABLE. Examples include:
- System load on the available processors
- Object Monitors currently held or requested by a thread
- Ownable Synchronizers (e.g. ReentrantLock and ReentrantReadWriteLock) held
by a thread
In short, you will more interesting information if you are running atop
JDK 6.
3- Mention somewhere that this information is gathered from the JDK provided
MBeans (and MXBeans).
4- Provide more examples and more importantly show the information of the
stack trace of a particular thread. I'd suggest showing an example of
"each" type by taking a portion of the output displayed when that command
is run.
-Kedar
Paul Davies wrote:
> Hi,
>
> Attached for review is the generate-jvm-report(1) man page, which I have
> updated as follows:
>
> * Fixed Issue 5162
> <https://glassfish.dev.java.net/issues/show_bug.cgi?id=5162>
> * Added information about --type=log as introduced by Issue 5803
> <https://glassfish.dev.java.net/issues/show_bug.cgi?id=5803>
> * In the Synopsis section, moved the [/target/] operand to after
> --type and formatted it to indicate that it is a placeholder
>
> Please also review the Description section, as some things there seem
> incongruous to me:
>
> * "Domain Administration Service" looks like it should be "Domain
> Administration Server".
> * The sentence: "This command replaces the traditional techniques
> like sending ctrl+break or kill -3 signals to application
> server processes." seems unrelated to the purpose of this command.
> * The sentence "The command will not work if the target server
> instance is not running." sounds like it should be supplemented or
> maybe even replaced by the statement:"This command is supported in
> remote mode only.
>
> Please give me your feedback by end of day on Thursday.
>
> Thanks!
>
> --
> Paul Davies, Senior Technical Writer, Sun Microsystems, Inc.
> http://blogs.sun.com/techscribe/
>
>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net