admin@glassfish.java.net

CODE REVIEW for GlassFish 9.1ur1 IT 3775

From: Mike Wright <Michael.A.Wright_at_Sun.COM>
Date: Tue, 23 Oct 2007 09:25:05 -0700

Hi Jane, Kedar, Mark S.,


   Please look at the links to review materials below for this JBI CLI
commands hook enhancement in 9.1ur1:


> https://glassfish.dev.java.net/issues/show_bug.cgi?id=3775


   I'd like to get these changes committed today.


Regards,
Mike
---
Index into changes (ignore admin-gui changes being reviewed separately):
 > http://engwww.sfbay.sun.com/~mikewr/sierra/20071023/changes.txt
 > http://engwww.sfbay.sun.com/~mikewr/sierra/20071023/du-a.out
gf 9.1peur1 related diffs and files can be found starting here:
 > http://engwww.sfbay.sun.com/~mikewr/sierra/20071023/
and open-esb 9.1 peur1 branch related diffs and files can be found 
starting here:
 > http://engwww.sfbay.sun.com/~mikewr/sierra/20071022/
summary:
1. created new open-esb/ri-clients/jbi-admin-gui subproject (with one 
command: "upgrade-jbi-component"
2. updated open-esb/rl/src/cmn/bom to add new jar to promotion
3. updated two glassfish/admin-cli/template files to add 
jbi/lib/jbi-admin-cli.jar to classpath (dev-pro)
4. updated two glassfish/admin-ee/ee80/template files to add 
jbi/lib/jbi-admin-cli.jar to classpath (cluster-pro)
5. updated 
glassfish/admin-cli/commands/src/java/com/sun/enterprise/cli/commands/CLIDescriptor.xml 
to
  remove (previously-disabled) "Dummy" upgrade-jbi-component command.
6. updated 
glassfish/admin-cli/commands/src/java/com/sun/enterprise/cli/commands/JBICommand.java 
to make some static Strings protected; added getter for JBIAdminCommands 
field (for "future" use in new derived JBIExtensionCommands.java)
-/-