admin@glassfish.java.net

CODE REVIEW for GlassFish 9.1ur1 IT 3572, 3741, 3758

From: Mike Wright <Michael.A.Wright_at_Sun.COM>
Date: Tue, 23 Oct 2007 08:33:07 -0700

Hi Anissa, Ken,

   Below are links to online review materials for the following 9.1peur1
(9.1_01) GlassFish admin-gui issues:

> https://glassfish.dev.java.net/issues/show_bug.cgi?id=3572
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=3741
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=3758

Please review and let me know if you have comments, issues, or
questions. I'd like to commit these changes today.

Regards,
Mike
---
index into changes (ignore the GF IT 3775 admin-cli/admin-ee changes, 
which are being reviewed separately)
 > http://engwww.sfbay.sun.com/~mikewr/sierra/20071023/changes.txt
 > http://engwww.sfbay.sun.com/~mikewr/sierra/20071023/du-a.out
diffs and files can be found starting here:
 > http://engwww.sfbay.sun.com/~mikewr/sierra/20071023
summary of changes:
A. GF IT 3572 (3758) "NPE during JBI install using copy instead of 
uploade" fix:
--added setting of file name on copy path (regression due to early 3572 
changes)
 > + archiveBean.setArchiveAbsolutePath(filePath);
in JBIArchiveValidationHandler.java, see open-esb 9.1ur1 branch diff:
 > 
http://engwww.sfbay.sun.com/~mikewr/sierra/20071022/sierra9_1ur1-cvs-diff-c.out
the remaining changes in beans and related handlers all have to do with 
improved
logging I used to debug this problem.
 > > http://engwww.sfbay.sun.com/~mikewr/sierra/20071022
B. GF IT 3741 "JBI Tabs I18n" fix:
"moved" JBI Tab I18n keys from open-esb jbi-admin-gui Bundle.properties 
to glassfish admin-gui Strings.properties.
Updated .jsf/.inc files to use correct keys
 > 
http://engwww.sfbay/~mikewr/sierra/20071023/cvs-diff-c-String-properties.out
(found/fixed related I18n problem in Monitor tab when using JBI "copy" 
of tab .inc file).
-/-