admin@glassfish.java.net

Re: CODE REVIEW: FindBugs: admin-core/monitor/src/java/com/sun/enterprise/admin/monitor/stats/lb/InstanceStats.java

From: Bill Shannon <bill.shannon_at_sun.com>
Date: Fri, 04 May 2007 10:48:23 -0700

Lloyd L Chambers wrote:
> Bill,
>
> It says it's generated, but there have been several 4 checkins of the
> file, by me, tcfujii, raharsha, tcfujii. If it's (re) generated, those
> would be pointless.

It sure would be nice to have a definitive answer.

If the file will never be regenerated, the comment should indicate that.

> I can't speak to the use of intern(), that's the choice that was already
> made in that file in a few places. I preserved the behavior, rather
> than 2nd guess it.

Understood.