admin@glassfish.java.net

Re: CODE REVIEW: FindBugs: admin-core/monitor/src/java/com/sun/enterprise/admin/monitor/stats/lb/InstanceStats.java

From: Lloyd L Chambers <Lloyd.Chambers_at_Sun.COM>
Date: Fri, 04 May 2007 09:22:00 -0700

Bill,

Yes, apparently the tool generating the code did not insert the intern
() call.

Lloyd

On May 4, 2007, at 12:45 AM, Bill Shannon wrote:

> Lloyd L Chambers wrote:
>> TIMEOUT: 17:00 PST May 3
>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=2965
>> raharsha: com/sun/enterprise/admin/monitor/stats/lb/
>> InstanceStats.java:545:545 ES: Comparison of String parameter
>> using == or != in
>> com.sun.enterprise.admin.monitor.stats.lb.InstanceStats.fetchProperty
>> ByName(String) (H)
>
> This claims to be a generated file, is it really safe to change it?
>
> Why the use of "intern"? Is this performance critical code?
>
> Is it the tool that generates this file from the DTD that's not
> inserting
> the needed intern call?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>