admin@glassfish.java.net

Re: CODE REVIEW: FindBugs: admin-core/monitor/src/java/com/sun/enterprise/admin/monitor/stats/lb/InstanceStats.java

From: Bill Shannon <bill.shannon_at_sun.com>
Date: Fri, 04 May 2007 00:45:10 -0700

Lloyd L Chambers wrote:
> TIMEOUT: 17:00 PST May 3
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=2965
>
>
> raharsha:
> com/sun/enterprise/admin/monitor/stats/lb/InstanceStats.java:545:545 ES:
> Comparison of String parameter using == or != in
> com.sun.enterprise.admin.monitor.stats.lb.InstanceStats.fetchPropertyByName(String)
> (H)

This claims to be a generated file, is it really safe to change it?

Why the use of "intern"? Is this performance critical code?

Is it the tool that generates this file from the DTD that's not inserting
the needed intern call?