TIMEOUT: 17:00 PST May 3
https://glassfish.dev.java.net/issues/show_bug.cgi?id=2965
dpatil: com/sun/enterprise/config/serverbeans/validation/Result.java:
53:53 Nm: Method
com.sun.enterprise.config.serverbeans.validation.Result.Result() was
probably intended to be a constructor (H)
Index: admin/validator/src/java/com/sun/enterprise/config/serverbeans/
validation/Result.java
===================================================================
RCS file: /cvs/glassfish/admin/validator/src/java/com/sun/enterprise/
config/serverbeans/validation/Result.java,v
retrieving revision 1.4
diff -w -u -r1.4 Result.java
--- admin/validator/src/java/com/sun/enterprise/config/serverbeans/
validation/Result.java 25 Feb 2006 00:07:31 -0000 1.4
+++ admin/validator/src/java/com/sun/enterprise/config/serverbeans/
validation/Result.java 3 May 2007 18:54:11 -0000
@@ -25,6 +25,9 @@
import java.util.*;
import com.sun.enterprise.util.LocalStringManagerImpl;
+/**
+ <b>NOT THREAD SAFE (mutable variables not protected)</b>
+ */
public class Result {
public static final int PASSED = 0;
@@ -38,18 +41,18 @@
private String operationPrintName;
private String assertion;
private String testName;
- private Vector errorDetails = new Vector();
- private Vector goodDetails = new Vector();
- private Vector warningDetails = new Vector();
- private Vector naDetails = new Vector();
+ private final Vector errorDetails = new Vector();
+ private final Vector goodDetails = new Vector();
+ private final Vector warningDetails = new Vector();
+ private final Vector naDetails = new Vector();
//boolean debug = Verifier.getDebug();
- boolean debug = false;
+ final boolean debug = false;
/**
* Result Constructor
*
*/
- public void Result(){
+ public Result(){
}