admin@glassfish.java.net

CODE REVIEW: issue 2928 "revise/remove various log messages"

From: Lloyd L Chambers <Lloyd.Chambers_at_Sun.COM>
Date: Mon, 30 Apr 2007 16:35:37 -0700

TIMEOUT: May 1, 17:00 PST

https://glassfish.dev.java.net/issues/show_bug.cgi?id=2928

- added log message noting starting of MBeanServer
- modified log message in AdminService to (correctly) indicate that
SunoneInterceptor is enabled
- removed a commented-out block (AdminService) left in by mistake
from a prior checkin.
- removed a couple of System.out.printlns

Lloyd


RCS file: /cvs/glassfish/appserv-commons/src/java/com/sun/logging/
enterprise/system/core/LogStrings.properties,v
retrieving revision 1.5
diff -r1.5 LogStrings.properties
107a108
> pemain.mbeanserver_started=MBeanServer started: {0}

RCS file: /cvs/glassfish/appserv-commons/src/java/com/sun/logging/
enterprise/system/tools/admin/LogStrings.properties,v
retrieving revision 1.22
diff -r1.22 LogStrings.properties
17c17
< core.mbs_init_ok=ADM0001:MBeanServer initialized successfully
---
 > core.sunone_interceptor_enabled=ADM0001:SunoneInterceptor is now  
enabled
148c148
< mbean.init_amx_success=ADM1079: Initialization of AMX MBeans  
successful
---
 > mbean.init_amx_success=ADM1079: Initialization of AMX MBeans started
RCS file: /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/ 
admin/server/core/AdminService.java,v
retrieving revision 1.25
diff -r1.25 AdminService.java
294c294
<         sLogger.log(Level.INFO, "core.mbs_init_ok");
---
 >         sLogger.log(Level.INFO, "core.sunone_interceptor_enabled");
299,326d298
<     /*
<         MBeanServer mbs = null;
<         try {
<             SunoneInterceptor.setAdminContext(adminContext);
<             mbs = SunoneInterceptor.getMBeanServerInstance();
<             MBeanServerFactory.initialize(this, mbs);
<             AMXLoggingHook.enableLoggingHook();
<
<             if (adminContext != null) {
<                 adminContext.setMBeanServer(mbs);
<             }
<             sLogger.log(Level.INFO, "core.mbs_init_ok");
<             initCallFlow();
<
<             //initialize JKS properties.
<             setupJKS();
<         }
<         catch (Throwable t) {
<             sLogger.log(Level.FINEST, t.getMessage(), t);
<             if (isDas()) {
<                 sLogger.log(Level.SEVERE,  
"core.mbs_init_exception", t);
<             }
<             else {
<                 sLogger.log(Level.WARNING,  
"core.mbs_init_exception", t);
<             }
<             throw new ServerLifecycleException(t.getMessage());
<         }
<     */
966,968d937
<             System.out.println( "REGISTERED AMX LOADER: " +  
mAMXLoaderObjectName );
<             System.out.println( "MBeanServer class: " +  
getMBeanServer().getClass().getName() );
<