admin@glassfish.java.net

Code Review Needed

From: Byron Nevins <Byron.Nevins_at_Sun.COM>
Date: Thu, 09 Nov 2006 16:49:04 -0800

Checkin Payload #2 for new server startup

Enclosed is a zip file with all the changed and new source. There is
also a file with the diffs -- diffs.txt. Of course there aren't any
diffs for the 2 new files:

appserv-commons/src/java/com/sun/enterprise/util/natives/NativeUtils.java
appserv-commons/src/java/com/sun/enterprise/util/io/ProcessStreamDrainer.java

The diffs are 2016 lines long, this is a non-trivial code review!

A summary of what I've done will be coming to this email address within
a day or two...

Note that ASLauncher.java is NOT new code -- it is a modified version of
ProcessLauncher from the tools module -- so don't review the stuff in
ProcessLauncher (ASLauncher) that I didn't touch (there's plenty of
grist for the code review mill in the old code)