admin@glassfish.java.net

Re: Code review request

From: Byron Nevins <Byron.Nevins_at_Sun.COM>
Date: Thu, 21 Sep 2006 22:50:28 -0700

I agree. It has an unsettling feel to it...



Bill Shannon wrote:
> Byron Nevins wrote:
>> My original intention was to point out that the code was much better
>> than the other way -- which I see all the time -- that can generate a
>> NPE easily:
>>
>> if (System.getProperty(JKS_DB_PROPERTY).equals("true"))
>
> I understand, and of course the above code is wrong, I just find the
> "if constant equals variable" style disgusting.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>