admin@glassfish.java.net

Re: code review for issue 694

From: Bill Shannon <bill.shannon_at_sun.com>
Date: Thu, 21 Sep 2006 22:50:32 -0700

Byron Nevins wrote:
> * It's too bad that the chmod method is declared as protected
> rather than as nothing (package-private). If it was -- you could
> just change the caller code (3 places in the package) to pass in
> an array of args instead of doing all of that painful processing.
> But, since it is protected there could be another caller of the
> chmod anywhere in the other millions of lines of code, so forget
> this idea! Moral for interested readers: don't use protected
> unless it is necessary.

Can't you find all the subclasses and fix them as necessary?
This isn't a public API, right?

Or, if you're really paranoid, add another chmod method that
takes the arg array and change the callers to use it.