users@connector-spec.java.net

[connector-spec-users] [jsr322-experts] Re: Some internal review comments on the candidate draft

From: Sivakumar Thyagarajan <sivakumar.thyagarajan_at_oracle.com>
Date: Tue, 05 Feb 2013 21:08:33 +0530

Hi Jesper

On Tuesday 05 February 2013 07:52 PM, Jesper Pedersen wrote:
> Hi,
>
> On 02/05/2013 09:13 AM, Sivakumar Thyagarajan wrote:
...
> The JavaDoc for these annotations has some strange characters, and some
> copy'n'paste issues.
>
>> - SCHEMA: A new 1.7 resource adapter schema needs to be introduced. The
>> "transaction-SupportType" was defined in the Connectors 1.6 schema. In
>> EE7, now that the ConnectionFactoryDefinition element
>> ("connection-factory") refers to transaction support, we would need to
>> refactor the connectors schema to move this definition to the
>> javaee_7.xsd. I will update 20.7 and Appendix A to handle this change.
>>
>
> Absolutely not.
>
> The definition in javaee_7.xsd should reference the definition in
> connector-1_6.xsd.

The connector-1_6.xsd already refers to the javaee_6.xsd for common type
definitions. Though it is named 'javaee_6.xsd', it is just a generic
'parent' xsd that all component XSDs refer to.

The transaction-supportType was defined in the connector 1.6 schema
because at that time it was meant to be used only in @Connector.

Now that we could have the new resource definition annotations placed in
web and ejb applications and the application.xml descriptor,
transaction-support would need to be defined higher above. We don't
duplicate definitions.

Thanks
--Siva.

>
> Otherwise the metadata definitions would change.
>
> If that doesn't work for them they can duplicate the definition.
>
> Best regards,
> Jesper
>