Hi,
On 02/05/2013 09:13 AM, Sivakumar Thyagarajan wrote:
> I have received the following comments through internal reviews and
> comments. I will make the following changes and send out an updated spec
> version tomorrow EoD India time.
>
> - The spec has missed defining the container annotations
> @ConnectionFactoryDefinitions and @AdministeredObjectDefinitions in the
> spec, though they have been defined in the javadoc. I will add new
> sections under 18.9 for these container annotations.
>
Ok.
> - TYPO: Though 18.9.1 and 18.9.2 use the annotation element name
> "resourceAdapter", the examples in 18.9.1.1 and 18.9.1.2 of the current
> spec use "resourceAdapterName". I will fix the examples to use
> "resourceAdapter".
>
Ok.
The JavaDoc for these annotations has some strange characters, and some
copy'n'paste issues.
> - SCHEMA: A new 1.7 resource adapter schema needs to be introduced. The
> "transaction-SupportType" was defined in the Connectors 1.6 schema. In
> EE7, now that the ConnectionFactoryDefinition element
> ("connection-factory") refers to transaction support, we would need to
> refactor the connectors schema to move this definition to the
> javaee_7.xsd. I will update 20.7 and Appendix A to handle this change.
>
Absolutely not.
The definition in javaee_7.xsd should reference the definition in
connector-1_6.xsd.
Otherwise the metadata definitions would change.
If that doesn't work for them they can duplicate the definition.
Best regards,
Jesper