This change is no good. If you don't propagate the exception up to
JUnit, JUnit won't learn that there was a failure.
At the very least you have to rethrow the exception. I actually believe
this whole "e.printStackTrace()" is pointless, because once JUnit
catches the exception, it will print that out anyway.
What was the motivation for this change?
bhaktimehta_at_dev.java.net wrote:
> @@ -58,7 +57,10 @@
> Reader r = client.script.read();
> try {
> engine.eval(r, engine.getNameSpace(), client.script.getName() );
> - } finally {
> + }catch (Exception e ) {
> + e.printStackTrace();
> + }
> + finally {
> r.close();
> }
> } finally {
--
Kohsuke Kawaguchi
Sun Microsystems kohsuke.kawaguchi_at_sun.com