The changes have been completed.
Remember that you need to update your workspace because the directories
themes/messages
themes/javascript
themes/templates
themes/src/suntheme/props
No longer exist (i.e. are empty)
Make sure you checkout and update using the "-P" option.
Let me know if you encounter any problems.
Thanks.
-rick
richard ratta wrote:
> I am about to begin integrating the themes directory changes within
> the next hour.
> Please refrain from committing code to the themes directory untill
> after I complete
> the changes. There will be lots of commit messages since I am creating
> directories and
> moving files.
>
> Thanks
>
> -rick
>
> richard ratta wrote:
>
>> I think it is easier if I wait. I have it scripted so it just a matter
>> of checking out the latest themes dir.
>>
>> -rick
>>
>> Bob Yennaco wrote:
>>
>>> I currently have a small number of changes to images.properties and
>>> a #$%^&-load of changes to colorAndMedia.css and layout.css. The
>>> #$%^&-load is really 99.99% formatting of the table styles into
>>> something human-readable so I could understand and debug the table
>>> styles in order to make the 0.01% changes that are required. It was
>>> reformat them or quit my job! It's possible I'll be ready for the
>>> putback before COB today, otherwise tomorrow.
>>>
>>> I don't believe any of this significantly impacts the flag day
>>> event, nor should the flag day event impact me. Any conflicts can
>>> be easily managed. I just want to point this out so we're in sync -
>>> and just in case I'm wrong. I have no problem waiting until after
>>> flag day to putback my changes if that's preferable.
>>>
>>> richard ratta wrote:
>>>
>>>> I will be waiting until the end of today to perform these changes
>>>> since venky is changing code in the themes and there is a pending
>>>> putback there.
>>>>
>>>> NOTE THAT THIS WILL BE A FLAG DAY EVENT.
>>>> YOU WILL NEED TO EITHER GET A COMPLETELY NEW WORKSPACE
>>>> OR UPDATE YOUR CURRENT WORKSPACE ACCORDINGLY.
>>>>
>>>> Make sure you use the "-P" option to prune empty directories when
>>>> using "update" or "checkout".
>>>>
>>>> -rick
>>>>
>>>>>
>>>>>> I'd like change the hierarchy in the themes module as we've
>>>>>> discussed
>>>>>> several times over the past months. This will be a build time
>>>>>> change only.
>>>>>> The runtime organization will stay the same.
>>>>>>
>>>>>> The old directory structure
>>>>>>
>>>>>> themes/
>>>>>> javascript/
>>>>>> messages/
>>>>>> src/
>>>>>> suntheme/props
>>>>>> templates/
>>>>>>
>>>>>> New
>>>>>>
>>>>>> themes/
>>>>>> src/suntheme
>>>>>> messages/
>>>>>> properties/
>>>>>> javascript/
>>>>>> templates/
>>>>>>
>>>>>> I don't want to change the location of
>>>>>> "messages/messages.properties" to "properties/messages.properties"
>>>>>> because the "com.sun.webui.jsf.suntheme.messages" package has
>>>>>> been around
>>>>>> for a while I don't think it is a good idea to make it disappear.
>>>>>>
>>>>>> This reorg makes it a little easier to clone suntheme for a new
>>>>>> theme. I will be refactoring
>>>>>> the build.xml at a later point to make that process more obvious
>>>>>> in the build script.
>>>>>>
>>>>>> I think these directory change should be ok and should not affect
>>>>>> the branches of previous releases.
>>>>>>
>>>>>> Any objections ?
>>>>>>
>>>>>> If I don't hear any I will make this change tomorrow Sept. 6th.
>>>>>>
>>>>>> -rick
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_woodstock.dev.java.net
>>> For additional commands, e-mail: dev-help_at_woodstock.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_woodstock.dev.java.net
>> For additional commands, e-mail: dev-help_at_woodstock.dev.java.net
>>