Date: Wed, 7 Dec 2011 16:47:42 +0000
From: jfialli@java.net
To: commits@shoal.java.net
Message-Id: <4edf98ae53020_1866848124cf@jnxapp05z1.network.org.tmail>
Subject: [shoal~svn:1726] Fix issue where a network interface was not up but it did have an ipv6 ad
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Reply-To: commits@shoal.java.net
Errors-to: commits-owner@shoal.java.net
Precedence: list

Project:    shoal
Repository: svn
Revision:   1726
Author:     jfialli
Date:       2011-12-07 16:47:40 UTC
Link:       

Log Message:
------------
Fix issue where a network interface was not up but it did have an ipv6 address
assigned to it.  GMS was incorrectly using that IPv6 address as the members
ip address for point-to-point communications. (incorrectly)


Revisions:
----------
1726


Modified Paths:
---------------
branches/gms-transport-modules/gms/impl/src/main/java/com/sun/enterprise/mgmt/transport/NetworkUtility.java


Diffs:
------
Index: branches/gms-transport-modules/gms/impl/src/main/java/com/sun/enterprise/mgmt/transport/NetworkUtility.java
===================================================================
--- branches/gms-transport-modules/gms/impl/src/main/java/com/sun/enterprise/mgmt/transport/NetworkUtility.java	(revision 1725)
+++ branches/gms-transport-modules/gms/impl/src/main/java/com/sun/enterprise/mgmt/transport/NetworkUtility.java	(revision 1726)
@@ -263,8 +263,10 @@
                 continue;
             }
 
-            // removed check if multicast enabled.  Definitely not correct for non-multicast mode.
-            if( getNetworkInetAddress(anInterface, false) != null ||
+            // replaced isMulticast() check with just an isUp() check.
+            // Definitely not correct for non-multicast mode to not allow non-multicast network interfaces.
+            if( isUp(anInterface) &&
+                getNetworkInetAddress(anInterface, false) != null ||
                 getNetworkInetAddress(anInterface, true) != null ) {
                 firstInterface = anInterface;
                 break;