Bongjae Chang wrote:
> Hi Shreedhar and Joe,
>
> Thank you for reviewing it.
>
> The changes included Shoal issue #61 because my local code had been just based on it.
>
> I am sorry for not separating the issue #61 from initial commit version though this "Abstracting out the transport layer" issue is never dependent on issue #61.
>
> It was just for the purpose of testing several cases easily.
>
> i.g. MasterNode.java, ClusterViewManager.java, ViewWindowImpl.java and some files may not be based on current CVS version.
>
> If it is difficult for you to compare it with original Shoal version and look into the diffs, I will try to commit the files again after separating them.
>
> Please let me know if you need.
>
Bonjae,
Thanks for letting me know that the changes included shoal issue 61.
I will let you know if it would help to separate these changes out.
My past memory is that I was having trouble tracking the changes for
shoal issue 61
so I may need you to separate them. But let me look at diffs first and
confirm that
I have that need. I have several outstanding tasks due this week so I
may not have a chance
to look at your changes for several days.
-Joe
> Thanks!
> --
> Bongjae Chang
>
>
> ----- Original Message -----
> From: "Joseph Fialli" <Joseph.Fialli_at_Sun.COM>
> To: <dev_at_shoal.dev.java.net>
> Sent: Tuesday, June 09, 2009 6:00 AM
> Subject: Re: [Shoal-Dev] Abstracting out the transport layer of Shoal(Initial version was committed)
>
>
>
>> Shreedhar Ganapathy wrote:
>>
>>> Great work Bongjae. Joe and I will look into the diffs and respond soon.
>>>
>> Thanks Bongjae for this feature.
>>
>> I will be sure to look over the diffs and provide feedback.
>>
>> -Joe
>>
>>> best regards
>>>
>>> Shreedhar
>>>
>>> Bongjae Chang wrote:
>>>
>>>> Hi,
>>>>
>>>> I have committed sources which try to abstract out the transport
>>>> layer of Shoal to SHOAL_1_1_ABSTRACTING_TRANSPORT branch.
>>>>
>>>> I tried to use JXTA and Grizzly for transport layer experimentally.
>>>>
>>>> Moreover, you can run original Shoal version which has used JXTA with
>>>> not abstracting out transport layer because original sources and
>>>> package have been preserved.
>>>>
>>>> Then, about transport layer, 3 modes exist.
>>>>
>>>> 1. original JXTA version
>>>> Run with -DSHOAL_GROUP_COMMUNICATION_PROVIDE="jxta", this is default.
>>>>
>>>> 2. new JXTA version which is integrated in abstracting out the
>>>> transport layer
>>>> Run with -DSHOAL_GROUP_COMMUNICATION_PROVIDE="jxtanew"
>>>>
>>>> 3. grizzly version which is integrated in abstracting out the
>>>> transport layer.
>>>> Run with -DSHOAL_GROUP_COMMUNICATION_PROVIDE="grizzly"
>>>>
>>>> I think that JGroup could be integrated easily as well, but I didn't
>>>> try it yet. :)
>>>>
>>>> For more details, please see the "readme_transport_abstraction.txt"
>>>> file which explains package structure, how to compile, how to run and
>>>> todo list.
>>>>
>>>> You can download sources with SHOAL_1_1_ABSTRACTING_TRANSPORT tag in
>>>> current Shoal cvs.
>>>>
>>>> Note that this is just experimental version.
>>>>
>>>> I am looking forward to your feedback and advice.
>>>>
>>>> I will welcome any comments, feedbacks and criticism!
>>>>
>>>> I really hope that your opinions will be applied to this version and
>>>> I think that I need some helps. :)
>>>>
>>>> Without hesitation, try to review it!
>>>>
>>>> Thanks!
>>>>
>>>> PS) If you want and need to know more informations in detail about
>>>> this changes, please let me know.
>>>>
>>>> --
>>>> Bongjae Chang
>>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_shoal.dev.java.net
>> For additional commands, e-mail: dev-help_at_shoal.dev.java.net
>>
>>
>>
>>
>>