All,
I've updated Tomcat's implementation as follows:
- added RequestDispatcher.FORWARD_MAPPING
- added RequestDispatcher.INCLUDE_MAPPING
- s/getMatchType/getMappingMatch/
- added Mapping.getServletName()
- removed MappingMatch.IMPLICIT
The behaviour for forward/include is the same as for the other
forward/include attributes.
This will be included in the next milestone release (early May) be if
folks want to test this sooner than that, let me know and I'll publish a
snapshot.
Mark
On 07/04/2016 00:32, Stuart Douglas wrote:
> Yes, I think returning a mapping of *.jsp when the request is to /home
> would just cause confusion, as in this case the jsp implicit mapping
> does not have anything to do with the request.
>
> I am not sure about getDescriptor(), I can't really see a use case for
> it. A filter or servlet should not care where it came from, and a
> human should already know (or be easily able to find out by looking at
> the source).
>
> Stuart
>
> On Thu, Apr 7, 2016 at 9:27 AM, Greg Wilkins <gregw_at_webtide.com> wrote:
>>
>> On 7 April 2016 at 09:20, Stuart Douglas <stuart.w.douglas_at_gmail.com> wrote:
>>>
>>> I was just thinking about this a bit more and it might be useful to
>>> include the target Servlet name in the mapping result, so a filter could
>>> tell exactly what Servlet the request is targeted at (we could even take it
>>> one step further and include a list of the filter names that will process
>>> the request, although I don't know what the use case would be).
>>
>>
>>
>> So for clarity, I'm when we have a mapping like:
>>
>> <servlet>
>> <servlet-name>home</servlet-name>
>> <jsp-file>/jsp/Home.jsp</jsp-file>
>> </servlet>
>> <servlet-mapping>
>> <servlet-name>home</servlet-name>
>> <url-pattern>/home</url-pattern>
>> </servlet-mapping>
>>
>> The mapping reported will be the /home mapping rather than any *.jsp
>> implicit pattern.
>>
>> You are suggesting that we add getServletName to the Mapping, which in this
>> case would return "home" I see value in that.
>>
>> There may even be value in a getDescriptor() method that would give a text
>> description of what descriptor the mapping was from: web.xml, fragment
>> web.xml from a particular jar, annotation on a particular class etc.
>>
>>
>>
>>
>>
>>
>>
>> --
>> Greg Wilkins <gregw@webtide.com> CTO http://webtide.com