Thanks, Arjan
I would expect there are quite a few of these in the wild. Would surely be
nice to have a canonical version in the servlet spec. And it would improve
API symmetry with the HttpServlet.
I've put the two proposed classes up in a Github repo here:
https://github.com/eirbjo/httpfilter
Might be easier to get the discussion going that way.
Eirik.
On Wed, Sep 23, 2015 at 4:33 PM, arjan tijms <arjan.tijms_at_gmail.com> wrote:
> Hi,
>
> On Wed, Sep 23, 2015 at 2:10 PM, Eirik Bjørsnøs <eirbjo_at_gmail.com> wrote:
> >
> > Then perhaps also consider empty default methods for Filter.init and
> > Filter.destroy?
>
> Perhaps, or maybe go for the abstract class you mentioned below?
>
> > I did not get any kind of feedback on that proposal. I guess experts
> don't
> > write filters ;-)
>
> We did an abstract HttpFilter for OmniFaces ;) See
>
> https://github.com/omnifaces/omnifaces/blob/2.1/src/main/java/org/omnifaces/filter/HttpFilter.java
>
> Kind regards,
> Arjan Tijms
>