On 05/30/2012 03:22 AM, Remy Maucherat wrote:
> On Wed, 2012-05-30 at 10:56 +0200, Greg Wilkins wrote:
>> The email, the javadoc and the document do not appear to match.
>>
>> There are no javadocs for classes called NonBlockingInputSource and
>> NonBlockingOutputSink.
>> NonBlockingOutputSink is mentioned only once in the the document as a
>> comment to WriteListener.
>> The document says that ServletInputStream should have a method called
>> dataAvailable() but that is not in the javadoc (and how is that
>> different to InputStream.available() ?)
>>
>> confused!
> There are certainly glitches after the updates. The custom Reader and
> Writer go away, so the two output sink interfaces are quite useless, the
> methods can be placed directly in the ServletIS/OS instead.
Yes that's what we have done. If there are references to
NonBlockingInputSource and NonBlockingOutputSink in the document then
that's a bug. We will fix that. But as you point out - since we removed
the Readers and Writers the necessary methods have just been added to
SIS and SOS.
>
> There is SIS.isReady() (= dataAvailable() that is no longer there, = int
> available() if it returns 0) and isFinished(), and SOS.canWrite() (which
> could also be harmonized as isReady(), it would remain an intuitive
> name). Good luck finding the best name combo.
>
> I'll send more comments later.
>