jsr369-experts@servlet-spec.java.net

[jsr369-experts] Deprecated HttpServletRequestWrapper#isRequestedSessionIdFromUrl

From: Shing Wai Chan <shing.wai.chan_at_oracle.com>
Date: Thu, 13 Aug 2015 12:25:47 -0700

In Servlet 2.1, we have deprecated
HttpServletRequst#isRequestedSessionIdFromUrl().
However, we have not deprecated
HttpServletRequestWrapper#isRequestedSessionIdFromUrl.
(This seems to be an overlook.)
I plan to deprecate this API.
The changes is in [1] below.
Any comment. Please let me know.
Thanks.
      Shing Wai Chan

[1] (Note that in HttpServletRequest#isRequestedSessionIdFromUrl(), we
have @deprecated in javadoc. I have added @Deprecated, too.)
Index: src/main/java/javax/servlet/http/HttpServletRequest.java
===================================================================
--- src/main/java/javax/servlet/http/HttpServletRequest.java
(revision 64041)
+++ src/main/java/javax/servlet/http/HttpServletRequest.java (working
copy)
@@ -584,6 +584,7 @@
       * <code>false</code>

       */
+ @Deprecated
      public boolean isRequestedSessionIdFromUrl();

      /**
Index: src/main/java/javax/servlet/http/HttpServletRequestWrapper.java
===================================================================
--- src/main/java/javax/servlet/http/HttpServletRequestWrapper.java
(revision 64041)
+++ src/main/java/javax/servlet/http/HttpServletRequestWrapper.java
(working copy)
@@ -322,7 +322,11 @@
      /**
       * The default behavior of this method is to return
isRequestedSessionIdFromUrl()
       * on the wrapped request object.
+ *
+ * @deprecated As of Version 2.1 of the Java Servlet API,
+ * use {_at_link #isRequestedSessionIdFromURL} instead.
       */
+ @Deprecated
      @Override
      public boolean isRequestedSessionIdFromUrl() {
          return
this._getHttpServletRequest().isRequestedSessionIdFromUrl();