On Wed, 2012-05-30 at 10:56 +0200, Greg Wilkins wrote:
> The email, the javadoc and the document do not appear to match.
>
> There are no javadocs for classes called NonBlockingInputSource and
> NonBlockingOutputSink.
> NonBlockingOutputSink is mentioned only once in the the document as a
> comment to WriteListener.
> The document says that ServletInputStream should have a method called
> dataAvailable() but that is not in the javadoc (and how is that
> different to InputStream.available() ?)
>
> confused!
There are certainly glitches after the updates. The custom Reader and
Writer go away, so the two output sink interfaces are quite useless, the
methods can be placed directly in the ServletIS/OS instead.
There is SIS.isReady() (= dataAvailable() that is no longer there, = int
available() if it returns 0) and isFinished(), and SOS.canWrite() (which
could also be harmonized as isReady(), it would remain an intuitive
name). Good luck finding the best name combo.
I'll send more comments later.
--
Remy Maucherat <rmaucher_at_redhat.com>
Red Hat Inc