jsr340-experts@servlet-spec.java.net

[jsr340-experts] Re: SERVLET_SPEC-23: Help prevent infinite loops

From: Remy Maucherat <rmaucher_at_redhat.com>
Date: Thu, 22 Dec 2011 08:55:36 +0100

On Wed, 2011-12-21 at 17:21 -0800, Shing Wai Chan wrote:
> The check should not be complicated or too costly as each corresponding
> vertex has only one outgoing edge
> and also in general there is not too many vertex in the corresponding graph.
> But I understand the concern that it may introduce an overhead (no
> matter how small it is).
> I prefer either check it or do not check it.

I would like to not have the check (alternately, it could be optional).

Since we're examining that area, would it be possible to consider
relaxing the requirement at the beginning of section 9.2 (where the
container has to look at all wrappers types, and is an expensive check
that also does not provide anything). It would be possible to keep the
requirement in for users, but not imply that the container must check
this. In Tomcat, this corresponds to the
org.apache.catalina.core.ApplicationDispatcher.checkSameObjects method.

-- 
Remy Maucherat <rmaucher_at_redhat.com>
Red Hat Inc