WildCart in Collections is a really good point.
instead create the EnumSet, I prefer a Set method, so:
public <T> Set<T> fromJsonSet(String str, Class<T> type) throws
JsonbException;
About the Object, I prefer to return a kind of JSONObject.
JSONObject obj = jsonb.fromJson(...);
On Wed, Feb 18, 2015 at 9:29 AM, Przemyslaw Bielicki <pbielicki_at_gmail.com>
wrote:
> Guys,
>
> after reviewing MartinV's code I saw we have couple of exceptions to the
> generic types and we have too many casts (which I personally hate), namely:
>
> 1. List/Collection
> 2. Map
> 3. Object
> 4. EnumSet
> 5. EnumMap
>
> I propose following shortcut methods which will allow JSON-B users
> avoiding casts:
>
> public <T> List<T> fromJsonList(String str, Class<T> type) throws
> JsonbException;
> public <T> Map<String, T> fromJsonMap(String str, Class<T> type) throws
> JsonbException;
> public <T> T fromJson(String str) throws JsonbException; // assume
> Object.class as a type
> public <E extends Enum<E>> EnumSet<E> fromJsonEnumSet(String str, Class<E>
> type) throws JsonbException;
> public <E extends Enum<E>, T> EnumMap<E, T> fromJsonEnumMap(String str,
> Class<E> enumType, Class<T> valueType) throws JsonbException;
>
> Of course, we'd need to overload these methods with Reader, InputStream
> and File in place of String.
>
> In such case some of the examples could be done this way:
>
> List<String> list = jsonb.fromJsonList(..., String.class);
> Map<String, Integer> map = jsonb.fromJsonMap(..., Integer.class);
> Object obj = jsonb.fromJson(...);
> EnumSet<Language> languageEnumSet1 = jsonb.fromJsonEnumSet(...,
> Language.class);
> EnumMap<Language, String> languageEnumMap1 = jsonb.fromJsonEnumMap(...,
> Language.class, String.class);
>
>
> What do you think?
>
> Przemyslaw
>
> On Tue, Feb 17, 2015 at 8:40 PM, Przemyslaw Bielicki <pbielicki_at_gmail.com>
> wrote:
>
>> Hi Martin,
>>
>> thanks for sharing this.
>>
>> First comment is the same I made to MartiNG: I would appreciate your test
>> in a form of JUnit test. You put a lot of effort in this and you will have
>> to rewrite / refactor a lot of code to make it unit test after all. Yes, I
>> know it should not and does not run but I just don't see the value of
>> main() method instead of proper JUnit class(es) - (you even implemented
>> your own assertEquals method - don't want to be impolite but it just does
>> not make sense :).
>>
>> I don't understand these lines:
>>
>> Map<String, Object> map =
>> (LinkedHashMap<String,Object>)jsonb.fromJson("{\"name\":\"unknown
>> object\"}", Object.class);
>>
>> Collection<Object> collection =
>> (ArrayList<Object>)jsonb.fromJson("[{\"value\":\"first\"},
>> {\"value\":\"second\"}]", Object.class);
>>
>> Why did you use Object.class parameter instead of Map.class and
>> Collection.class accordingly?
>>
>> This is kind of verbose (IMO unnecessarily):
>>
>> EnumSet<Language> languageEnumSet1 =
>> (EnumSet<Language>)jsonb.fromJson("[\"Slovak\", \"English\"]",
>> DefaultMapping.class.getField("languageEnumSet").getType());
>>
>> EnumMap<Language, String> languageEnumMap1 = (EnumMap<Language,
>> String>)jsonb.fromJson("[\"Slovak\" : \"sk\", \"Czech\" : \"cz\"]",
>> DefaultMapping.class.getField("languageEnumMap").getType());
>>
>> I would change it to:
>>
>> EnumSet<Language> languageEnumSet1 = jsonb.fromJson("[\"Slovak\",
>> \"English\"]", languageEnumSet.getClass());
>> EnumMap<Language, String> languageEnumMap1 = (EnumMap<Language,
>> String>)jsonb.fromJson("[\"Slovak\" : \"sk\", \"Czech\" : \"cz\"]",
>> languageEnumMap.getClass());
>>
>> this also requires adding static keyword to languageEnumSet and
>> languageEnumMap fields.
>>
>> In the inheritance test the input and output JSONs are not the same:
>> {"age":5, "dog":{"name":"Rex"}}
>> vs.
>> {"age":5,"name":"Rex"}
>>
>> it's a typo?
>>
>> Expect few more comments from my side. I'm short in time this week, thus
>> I need to split my email into smaller pieces.
>>
>> Cheers,
>> Przemyslaw
>>
>> On Fri, Feb 13, 2015 at 8:26 PM, Martin Vojtek <martin.vojtek_at_oracle.com>
>> wrote:
>>
>>> Hi,
>>>
>>> I have pushed new branch default_mapping, which contains initial
>>> examples for default mapping.
>>>
>>> There are also comments, which contain information about concepts like
>>> null handling and default field access strategy.
>>>
>>> Default mapping of dates and generics handling is not part of this
>>> commit and will be addressed separately.
>>>
>>> Looking forward to your feedback.
>>>
>>> Thank you,
>>> Martin Vojtek
>>
>>
>>
>
--
Otávio Gonçalves de Santana
blog: http://otaviosantana.blogspot.com.br/
twitter: http://twitter.com/otaviojava
site: *http://about.me/otaviojava <http://about.me/otaviojava>*
55 (11) 98255-3513