Bugs reported by FindBugs need to be fixed:
https://jsftemplating.dev.java.net/issues/show_bug.cgi?id=14
Issue #|14
Summary|Bugs reported by FindBugs need to be fixed
Component|jsftemplating
Version|current
Platform|Windows
OS/Version|All
URL|
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|Other
Assigned to|kenpaulsen
Reported by|anilam
------- Additional comments from anilam_at_dev.java.net Fri Mar 23 05:08:55 +0000 2007 -------
Here is the 3 bugs reported by findbugs when building glassfish.
This should be fixed if possible.
=======================
In class com.sun.jsftemplating.util.LayoutElementUtil
Field com.sun.jsftemplating.util.LayoutElementUtil.MAX_ID
At LayoutElementUtil.java:[line 173]
com.sun.jsftemplating.util.LayoutElementUtil.MAX_ID isn't final but should be
A mutable static field could be changed by malicious code or by accident from another package. The field could be made
final to avoid this vulnerability.
=======================
In class com.sun.jsftemplating.el.PermissionChecker
Field com.sun.jsftemplating.el.PermissionChecker._tmpFunctionStack
At PermissionChecker.java:[line 1295]
Field only ever set to null: com.sun.jsftemplating.el.PermissionChecker._tmpFunctionStack
All writes to this field are of the constant value null, and thus all reads of the field will return null. Check for
errors, or remove it if it is useless.
=========================
n class com.sun.jsftemplating.layout.template.TemplateReader
Field com.sun.jsftemplating.layout.template.TemplateReader.EVENT_PARSER_COMMAND
At TemplateReader.java:[line 1152]
com.sun.jsftemplating.layout.template.TemplateReader.EVENT_PARSER_COMMAND isn't final but should be
A mutable static field could be changed by malicious code or by accident from another package. The field could be made
final to avoid this vulnerability.
============================