I like your suggestion. All of the changes you proposed should work well.
Thanks!
Ken
Anissa Lam wrote:
>
>
> Ken Paulsen wrote:
>> Ok, if you want a top-level flag specific to creator, I think it should
>> indicate that in its name. The lib/external directory is not Creator
>> specific so it shouldn't be able to point to a Creator directory. Also
>> it may be fine to do this at the Samples level as I have no plans to
>> make the core part of JSFTemplating specific to any component library,
>> and therefor shouldn't ever need the Creator jars.
>>
> You are right. Now i think that maybe the external jars should be
> under samples instead of the top level. <jsftemplating>/samples/lib
> and place a copy of the jars there.
>> Also, keep in mind that the "build.properties" file is not checked
>> in. The idea is that this file is normally customized, so instead the
>> build.properties.example is checked in.... perhaps we should revisit
>> this. This means that additions/modifications to the
>> build.properties.example are not picked up automatically... and therefor
>> it may break everyone's build until they manually fix it (as in this
>> case).
>>
> I keep thinking about the case where people will copy over
> build.properties.example to build.properties and so there shouldn't be
> any problem. Sorry that I completely missed the case for 'existing'
> user where they won't copy the build.properties.sample again once they
> have the project setup and working. How about the following changes:
>
> - remove the properties external from build.properties.sample
> - put a copy of the 3 jars to samples/lib, - add a property in
> samples/build.properties that point to this lib, and all the samples
> will reference this. User can change this to point to other
> directory if they prefer.
>
> What do you think ?
>
> Anissa.
>> Ken
>>
>> Anissa Lam wrote:
>>
>>> Ken Paulsen wrote:
>>>
>>>> Hi Anissa,
>>>>
>>>> The samples/editor/build.xml needs ${external} defined -- I also
>>>> see you
>>>> added this at the top-level build.properties.example file.
>>>>
>>>> It is easy for developers to copy this value to their own
>>>> build.properties file... however, perhaps we can do without this
>>>> change? Instead of samples/editor/build.properties file defining:
>>>>
>>>> external.lib.dir=../../${external}
>>>>
>>>> Perhaps it could define it like:
>>>>
>>>> external.lib.dir=../../${lib}/external
>>>>
>>>> What do you think?
>>>>
>>> I defined external in the top level build.properties
>>> external=${lib}/external thinking that this will allow user to
>>> specify where the 3 jars
>>> (webui.jar,dataprovider.jar,defaulttheme.jar) are, in case they
>>> already have creator installed somewhere and don't want to copy them
>>> over. Just to be a little more flexible. Either way will work and
>>> is fine with me.
>>>
>>> thanks
>>> Anissa.
>>>
>>>> Ken
>>>>