>>>>> On Wed, 05 Sep 2007 19:11:35 -0700, Matthew Bohm <Matthew.Bohm_at_Sun.COM> said:
MB> Ed,
MB> Just to verify, please see the attached new diff. For consistency, I
MB> also modified the addPhaseListener logic to check for equals. BTW, we
MB> actually could just do...
MB> public void addPhaseListener(PhaseListener phaseListener) {
MB> parent.addPhaseListener(phaseListener);
MB> }
MB> ...rather than...
MB> public void addPhaseListener(PhaseListener phaseListener) {
MB> if (!parentHasListener(phaseListener)) {
MB> parent.addPhaseListener(phaseListener);
MB> }
MB> }
MB> ...since we are now removing redundancies in the execute method. I'm not
MB> sure it matters. I guess I prefer to retain the parentHasListener check,
MB> but don't mind either way.
I prefer to keep it as well, to minimize number of lines changed.
MB> So let me know if these changes are what you meant, and/or if you have a
MB> preference for addPhaseListener.
I like it there too.
r=edburns
Ed
--
| 157 Business Days until JavaOne 2008
| ed.burns_at_sun.com | office: 408 884 9519 OR x31640
| homepage: | http://purl.oclc.org/NET/edburns/
| aim: edburns0sunw | iim: ed.burns_at_sun.com