I received a mail today which confirmed that my signature was accepted. Looking forward to having my fix reviewed!
Regards, Rafael
From: Rafael Winterhalter [mailto:Rafael.Winterhalter_at_kantega.no]
Sent: Tuesday, November 12, 2013 3:50 PM
To: users_at_jersey.java.net
Subject: [Jersey] Re: Jersey client: Asynchronous requests
Hi Marek,
Thank you for your quick reply. I sent in the agreement.
I just wanted to add that I was not able to run the unit tests of the current snapshot without test failures (without my changes). Also, the GitHub CloudBees gives me errors. I would not know how to fix either.
Best regards, Rafael
From: Marek Potociar [mailto:marek.potociar_at_oracle.com]
Sent: Tuesday, November 12, 2013 3:27 PM
To: users_at_jersey.java.net<mailto:users_at_jersey.java.net>
Subject: [Jersey] Re: Jersey client: Asynchronous requests
Hi Rafael,
Thank you for both contributions. Before we can proceed with the review & eventually accept these pull requests, we need to ask you to sign Oracle Contributors Agreement (OCA):
http://www.oracle.com/technetwork/community/oca-486395.html
From the linked page:
An OCA can be remitted for acceptance by emailing a scanned, completed, signed copy to oracle-ca_us [at] oracle [dot] com. Or, you may use that email address to request a fax number for remittance of hard copy.
Thank you,
Marek
On 12 Nov 2013, at 14:39, Rafael Winterhalter <Rafael.Winterhalter_at_kantega.no<mailto:Rafael.Winterhalter_at_kantega.no>> wrote:
Hey,
I suggested to changes to the Jersey client's asynchronous behavior since I was recently implementing a bigger Jersey client application and I did not find the Jersey client to work as expected:
https://github.com/jersey/jersey/pull/38
https://github.com/jersey/jersey/pull/39
I do of course not know if you want to consider my code changes but I strongly suggest to update the Java doc of ClientProperties.ASYNC_THREADPOOL_SIZE since it does not inform about the fact that this property is currently ignored. This is merely noted in a TODO in the source code and thus not as visible as it should be.
Best, Rafael